Merge ~lucaskanashiro/ubuntu/+source/rubygems:fix-ftbfs-jammy into ubuntu/+source/rubygems:ubuntu/jammy-devel

Proposed by Lucas Kanashiro
Status: Needs review
Proposed branch: ~lucaskanashiro/ubuntu/+source/rubygems:fix-ftbfs-jammy
Merge into: ubuntu/+source/rubygems:ubuntu/jammy-devel
Diff against target: 35 lines (+9/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+3/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
git-ubuntu import Pending
Review via email: mp+423957@code.launchpad.net

Description of the change

Fix FTBFS. This fix was applied in rubygems/3.3.15-1 in kinetic/proposed.

PPA with proposed fix:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/rubygems-fix/+packages

autopkgtest is happy:

autopkgtest [17:11:16]: @@@@@@@@@@@@@@@@@@@@ summary
testsuite SKIP unknown restriction needs-internet
bundle-gem PASS
bundle-bin-path PASS
smoke-test PASS
gem2deb-test-runner PASS

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

What about these git messages, would we enable more tests if git was installed?

Pending: test_to_s_git(TestGemRequestSetLockfile): cannot find git executable, use GIT environment variable to set
/<<PKGBUILDDIR>>/test/rubygems/helper.rb:592:in `have_git?'
/<<PKGBUILDDIR>>/test/rubygems/helper.rb:552:in `git_gem'
/<<PKGBUILDDIR>>/test/rubygems/test_gem_request_set_lockfile.rb:375:in `test_to_s_git'
     372: end
     373:
     374: def test_to_s_git
  => 375: _, _, repository, = git_gem
     376:
     377: head = nil
     378:

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Yes, if we add git as a b-d we would be able to run more tests, but in Debian we do not want to add such a package as a b-d (think about transitions and so on).

Revision history for this message
Andreas Hasenack (ahasenack) :
review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

you will send this one-liner to debian as well, right?

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I fixed it in Debian first :) This is in version 3.3.15-1 in kinetic/proposed already.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the review Andreas. Package uploaded:

Uploading rubygems_3.3.5-2ubuntu1.dsc
Uploading rubygems_3.3.5-2ubuntu1.debian.tar.xz
Uploading rubygems_3.3.5-2ubuntu1_source.changes

Unmerged commits

2d7eea0... by Lucas Kanashiro

update-maintainer

b833ad7... by Lucas Kanashiro

Update changelog

7bcfdf8... by Lucas Kanashiro

Add ruby-test-unit (>= 3.3.9~) as b-d (LP: #1976264)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 6f8a207..f0ed1cd 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+rubygems (3.3.5-2ubuntu1) jammy; urgency=medium
7+
8+ * d/control: add ruby-test-unit (>= 3.3.9~) as b-d (LP: #1976264).
9+
10+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Fri, 03 Jun 2022 16:15:53 -0300
11+
12 rubygems (3.3.5-2) unstable; urgency=medium
13
14 * Don't consider gems provided by Debian packages as deleted
15diff --git a/debian/control b/debian/control
16index fe74943..3bef2a5 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -1,13 +1,15 @@
20 Source: rubygems
21 Section: ruby
22 Priority: optional
23-Maintainer: Debian Ruby Team <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Debian Ruby Team <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
26 Uploaders: Lucas Kanashiro <kanashiro@debian.org>
27 Build-Depends: debhelper-compat (= 13),
28 gem2deb (>= 1),
29 rake,
30 ruby,
31 ruby-dev,
32+ ruby-test-unit (>= 3.3.9~),
33 ruby-webrick (>= 1.7.0)
34 Standards-Version: 4.6.0
35 Vcs-Git: https://salsa.debian.org/ruby-team/rubygems.git

Subscribers

People subscribed via source and target branches