Ubuntu
ruby2.5 package

Code review comment for ~lucaskanashiro/ubuntu/+source/ruby2.5:bionic-arm64-optimization

  1. Git
  2. lp:~lucaskanashiro/ubuntu/+source/ruby2.5
  3. bionic-arm64-optimization
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the review Bryce! I believe I addressed all your comments, it is up for review again. I uploaded a new version to the PPA with the all the improvements.

Regarding the autopkgtest failure I was not able to reproduce it, I ran it locally multiple times with different backends and all of them passed:

autopkgtest [18:38:52]: @@@@@@@@@@@@@@@@@@@@ summary
run-all PASS
bundled-gems PASS
builtin-extensions PASS
rubyconfig PASS

I tested with the commands below:

$ autopkgtest -U -s ruby2.5_2.5.1-1ubuntu1.7~ppa4_amd64.changes -- lxd ubuntu-daily:bionic
$ autopkgtest -U -s ruby2.5_2.5.1-1ubuntu1.7~ppa4_amd64.changes -- qemu @autopkgtest-bionic.cfg
$ cat autopkgtest-bionic.cfg
--ram-size=2046
/home/lucas/autopkgtest/autopkgtest-bionic-amd64.img

Here you can find the log of one of my executions: https://paste.ubuntu.com/p/H2fHr4y7Yb/

« Back to merge proposal