Merge ~lucaskanashiro/ubuntu/+source/resource-agents:promote-iscsi-agents into ubuntu/+source/resource-agents:ubuntu/devel

Proposed by Lucas Kanashiro
Status: Merged
Merged at revision: 8cdca8b0c0b47fa05cbbe91f211cf5291d717a36
Proposed branch: ~lucaskanashiro/ubuntu/+source/resource-agents:promote-iscsi-agents
Merge into: ubuntu/+source/resource-agents:ubuntu/devel
Diff against target: 46 lines (+20/-0)
3 files modified
debian/changelog (+9/-0)
debian/control (+8/-0)
debian/curated-agents (+3/-0)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server Pending
git-ubuntu import Pending
Review via email: mp+416053@code.launchpad.net

Description of the change

Promote iscsi, iSCSITarget and iSCSILogicalUnit agents to the base package.The jenkins job for them are already in place and passing.

autopkgtest is happy:

autopkgtest [17:02:26]: @@@@@@@@@@@@@@@@@@@@ summary
IPaddr2 PASS
command1 PASS
command2 PASS
command3 PASS
command4 PASS
command5 PASS
command6 PASS
command7 PASS
command8 PASS
command9 PASS
command10 PASS
command11 PASS
command12 PASS
command13 PASS

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Lucas,

I am taking this one.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM!

Thanks, Lucas

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Athos. Package uploaded:

$ dput ubuntu ../resource-agents_4.7.0-1ubuntu6_source.changes
Checking signature on .changes
gpg: ../resource-agents_4.7.0-1ubuntu6_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../resource-agents_4.7.0-1ubuntu6.dsc: Valid signature from F823A2729883C97C
Package includes an .orig.tar.gz file although the debian revision suggests
that it might not be required. Multiple uploads of the .orig.tar.gz may be
rejected by the upload queue management software.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading resource-agents_4.7.0-1ubuntu6.dsc: done.
  Uploading resource-agents_4.7.0.orig.tar.gz: done.
  Uploading resource-agents_4.7.0-1ubuntu6.debian.tar.xz: done.
  Uploading resource-agents_4.7.0-1ubuntu6_source.buildinfo: done.
  Uploading resource-agents_4.7.0-1ubuntu6_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index ed75f98..2e724ec 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+resource-agents (1:4.7.0-1ubuntu6) jammy; urgency=medium
7+
8+ * d/curated-agents: add iSCSI resource agents.
9+ They are iscsi, iSCSILogicalUnit and iSCSITarget.
10+ * d/control: suggest packages used by the agents in the base binary package
11+ (LP: #1863677).
12+
13+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Thu, 24 Feb 2022 11:58:58 -0300
14+
15 resource-agents (1:4.7.0-1ubuntu5) impish; urgency=medium
16
17 * d/curated-agents: add LVM-activate agent.
18diff --git a/debian/control b/debian/control
19index 4265cb2..d42893e 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -78,6 +78,14 @@ Package: resource-agents-base
23 Architecture: all
24 Depends: ${misc:Depends},
25 resource-agents-common (>= ${source:Version})
26+Suggests:
27+# for iscsi agent
28+ open-iscsi,
29+# for iSCSITarget and iSCSILogicalUnit agents (the recommended implementation is lio-t)
30+ targetcli-fb,
31+# for LVM-activate agent
32+ dmsetup,
33+ lvm2
34 Replaces: cluster-agents (<= 1:1.0.4-1),
35 rgmanager (<= 3.0.12-2+b1),
36 resource-agents (<< 1:4.7.0-1ubuntu2)
37diff --git a/debian/curated-agents b/debian/curated-agents
38index 0bbb25a..4cf27cd 100644
39--- a/debian/curated-agents
40+++ b/debian/curated-agents
41@@ -1,2 +1,5 @@
42 IPaddr2
43+iscsi
44+iSCSILogicalUnit
45+iSCSITarget
46 LVM-activate

Subscribers

People subscribed via source and target branches