Merge ~lucaskanashiro/ubuntu/+source/python-traceback2:fix-ftbfs into ubuntu/+source/python-traceback2:ubuntu/devel

[Lucas Kanashiro]

This package currently FTBFS because it build-depends on two binary packages that are not available in Focal:

* python-fixtures
* python-testtools

My first idea initially was to remove the python-traceback2 binary package and consequentially all its python 2 dependencies but its removal would require changes in many other packages. Check part of dependencies' chain below:

$ reverse-depends python-traceback2
Reverse-Depends
* python-unittest2

Packages without architectures listed are reverse-dependencies in: amd64, arm64, armhf, i386, ppc64el, s390x
$ reverse-depends -b python-traceback2
Reverse-Build-Depends-Indep
* unittest2
$ reverse-depends python-unittest2
$ reverse-depends -b python-unittest2
Reverse-Testsuite-Triggers
* contextlib2
* python-debian
* webdis

Reverse-Build-Depends
* configobj
* contextlib2
* python-concurrent.futures
* python-debian
* python-oauthlib
* python-phabricator
* python-zipp
* webdis

Reverse-Build-Depends-Indep
* python-funcsigs
* python-future
* python-linecache2
* python-mock
* python-traceback2
* python-trollius

To avoid changes in many packages during beta freeze, my proposal is just to remove the build-dependency on those two binary packages (python-fixtures and python-testtools) because they are test dependencies and do not run build time tests.

Here is my PPA with the proposed package built:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/focal-python-traceback2-fix-ftbfs/+packages

[Bryce Harrington (bryce)]

Good analysis and the approach to address the problem seems sensible. LGTM, +1.

review: Approve

[Lucas Kanashiro (lucaskanashiro)]

Could you sponsor this package for me Bryce? TIA.

[James Page (james-page)]

I think this might be worth the small amount of pain:

$ reverse-depends python-traceback2
Reverse-Depends
* python-unittest2

Packages without architectures listed are reverse-dependencies in: amd64, arm64, armhf, i386, ppc64el, s390x

$ reverse-depends python-unittest2

[NO OUTPUT]

yes we'd need to RM py2 versions of traceback2 and unittest2 but that's the extent of the work.

[James Page (james-page)]

Actually no you are probably right - I'd missed the BD's in my listings.

review: Approve

[Lucas Kanashiro (lucaskanashiro)]

Changelog is now updated to close the bug, thanks for catching that!

[Lucas Kanashiro (lucaskanashiro)]

Could someone sponsor this package for me?

[Rafael David Tinoco (rafaeldtinoco)]

Yep, doing it.

[Rafael David Tinoco (rafaeldtinoco)]

$ git push pkg upload/1.4.0-5ubuntu1
Enumerating objects: 22, done.
Counting objects: 100% (22/22), done.
Delta compression using up to 8 threads
Compressing objects: 100% (17/17), done.
Writing objects: 100% (17/17), 2.22 KiB | 2.22 MiB/s, done.
Total 17 (delta 11), reused 0 (delta 0)
remote: Checking connectivity: 17, done.
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/python-traceback2
 * [new tag] upload/1.4.0-5ubuntu1 -> upload/1.4.0-5ubuntu1

$ dput ubuntu python-traceback2_1.4.0-5ubuntu1_source.changes
Checking signature on .changes
gpg: /home/rafaeldtinoco/work/sources/general/python-traceback2_1.4.0-5ubuntu1_source.changes: Valid signature from A93E0E0AD83C0D0F
Checking signature on .dsc
gpg: /home/rafaeldtinoco/work/sources/general/python-traceback2_1.4.0-5ubuntu1.dsc: Valid signature from A93E0E0AD83C0D0F
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading python-traceback2_1.4.0-5ubuntu1.dsc: done.
  Uploading python-traceback2_1.4.0.orig.tar.xz: done.
  Uploading python-traceback2_1.4.0-5ubuntu1.debian.tar.xz: done.
  Uploading python-traceback2_1.4.0-5ubuntu1_source.buildinfo: done.
  Uploading python-traceback2_1.4.0-5ubuntu1_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index d504802..3b42bee 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+python-traceback2 (1.4.0-5ubuntu1) focal; urgency=medium
+
+  * d/control: Do not build-depend on python-fixtures and python-testtools.
+    Those python 2 binary packages are not available in Focal (LP: #1870078).
+  * d/rules: Do not run tests because some dependencies are missing
+
+ -- Lucas Kanashiro <[e-mail]>  Tue, 31 Mar 2020 16:10:00 -0300
+
 python-traceback2 (1.4.0-5build1) focal; urgency=medium
 
   * No-change rebuild to generate dependencies on python2.
diff --git a/debian/control b/debian/control
index 87a8913..1ef7e33 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: python-traceback2
 Section: python
 Priority: optional
-Maintainer: Debian OpenStack <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian OpenStack <[e-mail]>
 Uploaders:
  Thomas Goirand <[e-mail]>,
 Build-Depends:
@@ -16,10 +17,8 @@ Build-Depends:
  python3-setuptools,
 Build-Depends-Indep:
  python-contextlib2,
- python-fixtures,
  python-linecache2,
  python-six,
- python-testtools,
  python-unittest2,
  python3-contextlib2,
  python3-fixtures,
diff --git a/debian/rules b/debian/rules
index 12911c4..3ef9f8a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -30,6 +30,11 @@ override_dh_clean:
 	dh_clean -O--buildsystem=python_distutils
 	rm -rf build .testrepository
 
+override_dh_auto_test:
+	echo "Not running tests because python-fixture and python-testtools \
+		were removed from Focal, and the removal of python-traceback2 \
+		would require a bunch of other removals during beta freeze"
+
 # Disable unit tests until there's a way to do it properly.
 #override_dh_auto_test:
 #ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))