Merge ~lucaskanashiro/ubuntu/+source/fence-agents:update-base-pkg into ubuntu/+source/fence-agents:ubuntu/devel

[Lucas Kanashiro]

Add the following fence agents to the fence-agent-base binary package:

- fence_sbd
- fence_ipmilan
  + fence_idrac
  + fence_ilo3
  + fence_ilo4
  + fence_ilo5
  + fence_imm
  + fence_ipmilanplus

In practice, fence_ipmilan and all the other agents added bellow it are the same, they are "symlinks" to fence_ipmilan.

Here is the FFe bug that I will wait to get it accepted before uploading the proposed changes:

https://bugs.launchpad.net/ubuntu/+source/fence-agents/+bug/1965312

I uploaded the package to this PPA:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/ha-stack/+packages

autopkgtest is still happy:

autopkgtest [12:15:57]: @@@@@@@@@@@@@@@@@@@@ summary
metadata PASS
delay PASS
fence-dummy PASS
fence-aws SKIP exit status 77 and marked as skippable

[Sergio Durigan Junior (sergiodj)]

I'll take a look at this one.

[Sergio Durigan Junior (sergiodj)]

Thanks for the MP, Lucas.

There's not much to review here other than the Suggests addition, so that's what I mostly focused on. I verified that the package builds fine locally and that autopkgtest is indeed OK.

I'm leaving a question for you regarding the Suggests part, let me know what you think.

Thanks.

review: Needs Information

[Lucas Kanashiro (lucaskanashiro)]

Thanks for the review Sergio. Replied to your comment, I hope this is enough to give you more context.

[Sergio Durigan Junior (sergiodj)]

Thanks for the explanation, Lucas. I'm totally fine with keeping it as Suggests now and revisiting things later.

LGTM, +1.

review: Approve

[Lucas Kanashiro (lucaskanashiro)]

FFe approved and package uploaded:

$ dput ubuntu ../fence-agents_4.7.1-1ubuntu8_source.changes
Checking signature on .changes
gpg: ../fence-agents_4.7.1-1ubuntu8_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../fence-agents_4.7.1-1ubuntu8.dsc: Valid signature from F823A2729883C97C
Package includes an .orig.tar.gz file although the debian revision suggests
that it might not be required. Multiple uploads of the .orig.tar.gz may be
rejected by the upload queue management software.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading fence-agents_4.7.1-1ubuntu8.dsc: done.
  Uploading fence-agents_4.7.1.orig.tar.gz: done.
  Uploading fence-agents_4.7.1-1ubuntu8.debian.tar.xz: done.
  Uploading fence-agents_4.7.1-1ubuntu8_source.buildinfo: done.
  Uploading fence-agents_4.7.1-1ubuntu8_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index 3e1f94a..1fcca07 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+fence-agents (4.7.1-1ubuntu8) jammy; urgency=medium
+
+  * d/curated-agents: add fence_ipmilan and fence_sbd to the -base package.
+    Also add the following agents which are symlinks to fence_ipmilan:
+    fence_idrac, fence_ilo3, fence_ilo4, fence_ilo5, fence_imm, and
+    fence_ipmilanplus (LP: #1965312).
+  * d/control: suggest dependecies of agents in the -base package (LP: #1863677)
+
+ -- Lucas Kanashiro <[e-mail]>  Thu, 17 Mar 2022 11:43:13 -0300
+
 fence-agents (4.7.1-1ubuntu7) impish; urgency=medium
 
   * d/rules: do not install /var/run directory anymore.
diff --git a/debian/control b/debian/control
index 064cfb1..0fc78e4 100644
--- a/debian/control
+++ b/debian/control
@@ -86,6 +86,17 @@ Architecture: all
 Multi-Arch: foreign
 Depends: ${misc:Depends}, ${python3:Depends},
          fence-agents-common (>= ${source:Version})
+Suggests:
+# for fence_ipmilan (and its symlinks)
+         ipmitool,
+# for fence_mpath
+         multipath-tools,
+# for fence_sbd
+         sbd,
+# for fence_scsi
+         sg3-utils,
+# for fence_virsh
+         libvirt-clients
 Breaks: cman (<= 3.0.12-2ubuntu4), fence-agents (<< 4.7.1-1ubuntu2)
 Replaces: cman (<= 3.0.12-2ubuntu4), fence-agents (<< 4.7.1-1ubuntu2)
 Description: Fence Agents for Red Hat Cluster curated by Ubuntu
diff --git a/debian/curated-agents b/debian/curated-agents
index 26e3dce..dcba8c2 100644
--- a/debian/curated-agents
+++ b/debian/curated-agents
@@ -1,3 +1,11 @@
+fence_idrac
+fence_ilo3
+fence_ilo4
+fence_ilo5
+fence_imm
+fence_ipmilan
+fence_ipmilanplus
 fence_mpath
+fence_sbd
 fence_scsi
 fence_virsh