Merge ~lucaskanashiro/ubuntu/+source/ethtool:fix-ethtool-module-info-mantic into ubuntu/+source/ethtool:ubuntu/mantic-devel

Proposed by Lucas Kanashiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Andreas Hasenack
Merged at revision: e35720ec28253664f0a057bd582a9ef104434294
Proposed branch: ~lucaskanashiro/ubuntu/+source/ethtool:fix-ethtool-module-info-mantic
Merge into: ubuntu/+source/ethtool:ubuntu/mantic-devel
Diff against target: 67 lines (+36/-1)
4 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/0001-Fix-ethtool-module-info-in-human-readable-mode.patch (+25/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Andreas Hasenack Approve
Canonical Server Reporter Pending
Review via email: mp+457364@code.launchpad.net

Description of the change

Import patch proposed by upstream to fix ethtool module info in human-readable mode. See LP: #2043983.

PPA: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/ethtool/+packages

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1, straightforward

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: lucaskanashiro, ahasenack
Uploaders: lucaskanashiro, ahasenack
MP auto-approved

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Andreas, package uploaded:

Uploading ethtool_6.5-1ubuntu0.1.dsc
Uploading ethtool_6.5-1ubuntu0.1.debian.tar.xz
Uploading ethtool_6.5-1ubuntu0.1_source.changes

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This was released, marking MP as merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 890a255..a586ed9 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+ethtool (1:6.5-1ubuntu0.1) mantic; urgency=medium
7+
8+ * d/p/0001-Fix-ethtool-module-info-in-human-readable-mode.patch: add
9+ upstream patch to avoid hex dump report even in human-readable mode
10+ (LP: #2043983).
11+
12+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Tue, 12 Dec 2023 17:32:39 -0300
13+
14 ethtool (1:6.5-1) unstable; urgency=medium
15
16 * New upstream release: 6.5
17diff --git a/debian/control b/debian/control
18index ed4d896..d7dbefb 100644
19--- a/debian/control
20+++ b/debian/control
21@@ -1,7 +1,8 @@
22 Source: ethtool
23 Section: net
24 Priority: optional
25-Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
26+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
27+XSBC-Original-Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
28 Uploaders: Ben Hutchings <benh@debian.org>, Salvatore Bonaccorso <carnil@debian.org>
29 Standards-Version: 4.6.2
30 Build-Depends: debhelper-compat (= 13), autoconf, automake, libmnl-dev, pkg-config
31diff --git a/debian/patches/0001-Fix-ethtool-module-info-in-human-readable-mode.patch b/debian/patches/0001-Fix-ethtool-module-info-in-human-readable-mode.patch
32new file mode 100644
33index 0000000..77916d8
34--- /dev/null
35+++ b/debian/patches/0001-Fix-ethtool-module-info-in-human-readable-mode.patch
36@@ -0,0 +1,25 @@
37+From: Lucas Kanashiro <lucas.kanashiro@canonical.com>
38+Date: Mon, 11 Dec 2023 18:49:23 -0300
39+Subject: Fix ethtool module info in human readable mode
40+
41+Origin: upstream, https://lists.openwall.net/netdev/2023/11/23/118
42+Forwarded: https://salsa.debian.org/kernel-team/ethtool/-/merge_requests/3
43+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/ethtool/+bug/2043983
44+Reviewed-By: Lucas Kanashiro <kanashiro@ubuntu.com>
45+Last-Updated: 2023-12-11
46+---
47+ netlink/module-eeprom.c | 1 +
48+ 1 file changed, 1 insertion(+)
49+
50+diff --git a/netlink/module-eeprom.c b/netlink/module-eeprom.c
51+index 09ad580..e9dd270 100644
52+--- a/netlink/module-eeprom.c
53++++ b/netlink/module-eeprom.c
54+@@ -216,6 +216,7 @@ static int eeprom_parse(struct cmd_context *ctx)
55+
56+ switch (request.data[0]) {
57+ #ifdef ETHTOOL_ENABLE_PRETTY_DUMP
58++ case SFF8024_ID_SOLDERED_MODULE:
59+ case SFF8024_ID_SFP:
60+ return sff8079_show_all_nl(ctx);
61+ case SFF8024_ID_QSFP:
62diff --git a/debian/patches/series b/debian/patches/series
63index e69de29..d500446 100644
64--- a/debian/patches/series
65+++ b/debian/patches/series
66@@ -0,0 +1 @@
67+0001-Fix-ethtool-module-info-in-human-readable-mode.patch

Subscribers

People subscribed via source and target branches