Merge ~lucaskanashiro/ubuntu/+source/clamav:focal-merge into ubuntu/+source/clamav:debian/sid

Proposed by Lucas Kanashiro
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 82d1397aa0f52e373edbaeb51a49a8eef111c96f
Merge reported by: Christian Ehrhardt 
Merged at revision: 82d1397aa0f52e373edbaeb51a49a8eef111c96f
Proposed branch: ~lucaskanashiro/ubuntu/+source/clamav:focal-merge
Merge into: ubuntu/+source/clamav:debian/sid
Diff against target: 179 lines (+109/-1)
3 files modified
debian/NEWS.Debian (+16/-0)
debian/changelog (+91/-0)
debian/control (+2/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+378895@code.launchpad.net

Description of the change

Merge version 0.102.2+dfsg2-2 from Debian. The entire delta we carry was dropped after merging this version. However, a small change was introduced in d/NEWS to warn users about the removal of some clamav-daemon options. We use to carry a patch to avoid a failure when those options are used, but after some discussion between the Server and Security teams we decided to drop this change now. After 20.04 we should be able to drop this small delta and then make it a sync from Debian.

Here is the PPA where build in all arches was successful:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/focal-clamav-merge-0.102.2+dfsg-1/+packages

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Perhaps "Some of clamav-daemon's options" instead of "Some clamav-daemon's options".

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

> Perhaps "Some of clamav-daemon's options" instead of "Some clamav-daemon's
> options".

Thanks for catching this, already fixed.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [√] old content match as expected
- [√] changelog entry correct version and targeted codename (I wanted to criticize until I saw it was the d/NEWS file :-) )
- [√] changelog entries correct
- [√] update-maintainer has been run

Actual changes:
- [√] debian and upstream changes look safe

Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop (ack that we have to wait post 20.04)
- [√] changes forwarded upstream/debian (not needed)

New Delta:
- [√] only new delta is the NEWS entry and that looks ok

Build/Test:
- [√] build is ok
- [√] verified PPA package installs/uninstalls
- [√] a few sanity checks test fine

So far all is fine, I'm running autopkgtests now, will let you know in a bit ...

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

autopkgtest [09:33:28]: @@@@@@@@@@@@@@@@@@@@ summary
clamd PASS
client PASS
milter PASS
qemu-system-x86_64: terminating on signal 15 from pid 3309 (/usr/bin/python3)

I think you are good to go.
Please catch any of us for sponsoring once you are active and there are no last-minute changes you want to make :-)

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/clamav
 * [new tag] upload/0.102.2+dfsg-1ubuntu1 -> upload/0.102.2+dfsg-1ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading clamav_0.102.2+dfsg-1ubuntu1.dsc: done.
  Uploading clamav_0.102.2+dfsg.orig.tar.xz: done.
  Uploading clamav_0.102.2+dfsg-1ubuntu1.debian.tar.xz: done.
  Uploading clamav_0.102.2+dfsg-1ubuntu1_source.buildinfo: done.
  Uploading clamav_0.102.2+dfsg-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/NEWS.Debian b/debian/NEWS.Debian
2index 5daa868..dc831d3 100644
3--- a/debian/NEWS.Debian
4+++ b/debian/NEWS.Debian
5@@ -1,3 +1,19 @@
6+clamav (0.102.2+dfsg-1ubuntu1) focal; urgency=medium
7+
8+ Some of clamav-daemon's options were removed by upstream for a while and from
9+ now on their usage will cause a failure during the start up process of this
10+ service. The following options are no longer supported:
11+ - StatsHostID
12+ - StatsEnabled
13+ - StatsPEDisabled
14+ - StatsTimeout
15+ - SubmitDetectionStats
16+ - DetectionStatsCountry
17+ - DetectionStatsHostID
18+ Make sure you are not using the options above.
19+
20+ -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Mon, 10 Feb 2020 13:39:26 -0300
21+
22 clamav (0.97.5+dfsg-1) unstable; urgency=medium
23
24 This release of clamav no longer ships signature files in clamav-base so
25diff --git a/debian/changelog b/debian/changelog
26index cea0072..303bf2d 100644
27--- a/debian/changelog
28+++ b/debian/changelog
29@@ -1,3 +1,20 @@
30+clamav (0.102.2+dfsg-1ubuntu1) focal; urgency=medium
31+
32+ * Merge with Debian unstable. Remaining changes:
33+ - d/NEWS.Debian: Warn users about the removal of some clamav-daemon options
34+ * Dropped:
35+ - clamav-daemon may fail to start due to options removed in new version
36+ and manually edited configuration file. (LP #1783632)
37+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
38+ add patch from Debian stretch to simply warn about removed options.
39+ - Update PO files. There is no need to carry a delta for this.
40+ - clamav-daemon: Correct error from ScanOnAccess option removal so that
41+ setting LogFile options via DebConf works again (Closes: #950296)
42+ (LP #1861497)
43+ [Applied by Debian in version 0.102.1+dfsg-3]
44+
45+ -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Mon, 10 Feb 2020 15:35:03 -0300
46+
47 clamav (0.102.2+dfsg-1) unstable; urgency=medium
48
49 * Import 0.102.2
50@@ -18,6 +35,24 @@ clamav (0.102.1+dfsg-3) unstable; urgency=medium
51
52 -- Scott Kitterman <scott@kitterman.com> Fri, 31 Jan 2020 16:49:37 -0500
53
54+clamav (0.102.1+dfsg-2ubuntu2) focal; urgency=medium
55+
56+ * d/clamav-daemon.config.in: Correct error from ScanOnAccess option
57+ removal so that setting LogFile options via DebConf works again.
58+ (Closes: #950296) (LP: #1860217)
59+
60+ -- Eric Desrochers <eric.desrochers@canonical.com> Thu, 06 Feb 2020 13:56:53 +0000
61+
62+clamav (0.102.1+dfsg-2ubuntu1) focal; urgency=medium
63+
64+ * Merge with Debian unstable. Remaining changes:
65+ - clamav-daemon may fail to start due to options removed in new version
66+ and manually edited configuration file. (LP #1783632)
67+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
68+ add patch from Debian stretch to simply warn about removed options.
69+
70+ -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Wed, 22 Jan 2020 09:37:47 -0300
71+
72 clamav (0.102.1+dfsg-2) unstable; urgency=medium
73
74 * Add the clamonacc binary to the clamav-daemon package.
75@@ -25,6 +60,16 @@ clamav (0.102.1+dfsg-2) unstable; urgency=medium
76
77 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Mon, 23 Dec 2019 20:54:21 +0100
78
79+clamav (0.102.1+dfsg-1ubuntu1) focal; urgency=medium
80+
81+ * Merge with Debian unstable. Remaining changes:
82+ - clamav-daemon may fail to start due to options removed in new version
83+ and manually edited configuration file. (LP #1783632)
84+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
85+ add patch from Debian stretch to simply warn about removed options.
86+
87+ -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Thu, 05 Dec 2019 18:01:14 -0300
88+
89 clamav (0.102.1+dfsg-1) unstable; urgency=medium
90
91 * Import 0.102.1 (Closes: #945265)
92@@ -36,6 +81,16 @@ clamav (0.102.1+dfsg-1) unstable; urgency=medium
93
94 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sat, 30 Nov 2019 19:22:15 +0100
95
96+clamav (0.101.4+dfsg-1ubuntu1) eoan; urgency=low
97+
98+ * Merge from Debian unstable. Remaining changes:
99+ - clamav-daemon may fail to start due to options removed in new version
100+ and manually edited configuration file. (LP #1783632)
101+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
102+ add patch from Debian stretch to simply warn about removed options.
103+
104+ -- Gianfranco Costamagna <locutusofborg@debian.org> Sun, 25 Aug 2019 23:25:27 +0200
105+
106 clamav (0.101.4+dfsg-1) unstable; urgency=medium
107
108 * Import 0.101.4
109@@ -47,6 +102,16 @@ clamav (0.101.4+dfsg-1) unstable; urgency=medium
110
111 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sun, 25 Aug 2019 12:38:25 +0200
112
113+clamav (0.101.2+dfsg-3ubuntu1) eoan; urgency=low
114+
115+ * Merge from Debian unstable. Remaining changes:
116+ - clamav-daemon may fail to start due to options removed in new version
117+ and manually edited configuration file. (LP #1783632)
118+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
119+ add patch from Debian stretch to simply warn about removed options.
120+
121+ -- Gianfranco Costamagna <locutusofborg@debian.org> Wed, 07 Aug 2019 08:54:47 +0200
122+
123 clamav (0.101.2+dfsg-3) unstable; urgency=medium
124
125 * Cherry-pick a fix from 0.101.3 to address a vulnerability to
126@@ -54,6 +119,16 @@ clamav (0.101.2+dfsg-3) unstable; urgency=medium
127
128 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Tue, 06 Aug 2019 21:42:06 +0200
129
130+clamav (0.101.2+dfsg-2ubuntu1) eoan; urgency=low
131+
132+ * Merge from Debian unstable. Remaining changes:
133+ - clamav-daemon may fail to start due to options removed in new version
134+ and manually edited configuration file. (LP #1783632)
135+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
136+ add patch from Debian stretch to simply warn about removed options.
137+
138+ -- Gianfranco Costamagna <locutusofborg@debian.org> Sat, 03 Aug 2019 10:20:31 +0200
139+
140 clamav (0.101.2+dfsg-2) unstable; urgency=medium
141
142 * Remove python from build-depends:
143@@ -63,6 +138,22 @@ clamav (0.101.2+dfsg-2) unstable; urgency=medium
144
145 -- Scott Kitterman <scott@kitterman.com> Fri, 02 Aug 2019 09:20:43 -0400
146
147+clamav (0.101.2+dfsg-1ubuntu2) eoan; urgency=medium
148+
149+ * Rebuild against new libjson-c4.
150+
151+ -- Gianfranco Costamagna <locutusofborg@debian.org> Sat, 29 Jun 2019 13:48:24 +0200
152+
153+clamav (0.101.2+dfsg-1ubuntu1) eoan; urgency=medium
154+
155+ * Sync with Debian. Remaining change:
156+ - clamav-daemon may fail to start due to options removed in new version
157+ and manually edited configuration file. (LP #1783632)
158+ + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
159+ add patch from Debian stretch to simply warn about removed options.
160+
161+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 23 Apr 2019 11:40:41 -0400
162+
163 clamav (0.101.2+dfsg-1) unstable; urgency=high
164
165 * Import 0.101.2
166diff --git a/debian/control b/debian/control
167index a635cf6..1e1cd53 100644
168--- a/debian/control
169+++ b/debian/control
170@@ -1,7 +1,8 @@
171 Source: clamav
172 Section: utils
173 Priority: optional
174-Maintainer: ClamAV Team <pkg-clamav-devel@lists.alioth.debian.org>
175+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
176+XSBC-Original-Maintainer: ClamAV Team <pkg-clamav-devel@lists.alioth.debian.org>
177 Uploaders: Michael Meskes <meskes@debian.org>,
178 Michael Tautschnig <mt@debian.org>,
179 Scott Kitterman <scott@kitterman.com>,

Subscribers

People subscribed via source and target branches