Merge ~lucaskanashiro/+git/ruby-webmock:fix-autopkgtest-in-ubuntu into ~lucaskanashiro/+git/ruby-webmock:master

Proposed by Lucas Kanashiro
Status: Approved
Approved by: Lucas Kanashiro
Approved revision: 2b7041dc99e64e7e2eb717efd02ab4512e9a2dcf
Proposed branch: ~lucaskanashiro/+git/ruby-webmock:fix-autopkgtest-in-ubuntu
Merge into: ~lucaskanashiro/+git/ruby-webmock:master
Diff against target: 46 lines (+15/-1)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/ruby-tests.rake (+7/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Review via email: mp+386622@code.launchpad.net

Description of the change

Fixed LP #1885760. This is a Ubuntu specific change so no need to forward it. The proposed change fixes autopkgtest of ruby-webmock as you can see here:

https://bileto.ubuntu.com/excuses/4123/groovy.html

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

You guarded the change well, debian can probably take it

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Andreas! Uploaded:

$ dput ubuntu ruby-webmock_3.8.3-1ubuntu1_source.changes
Checking signature on .changes
gpg: /home/kanashiro/packaging/ubuntu/ruby-webmock/ruby-webmock_3.8.3-1ubuntu1_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: /home/kanashiro/packaging/ubuntu/ruby-webmock/ruby-webmock_3.8.3-1ubuntu1.dsc: Valid signature from F823A2729883C97C
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ruby-webmock_3.8.3-1ubuntu1.dsc: done.
  Uploading ruby-webmock_3.8.3-1ubuntu1.debian.tar.xz: done.
  Uploading ruby-webmock_3.8.3-1ubuntu1_source.changes: done.
Successfully uploaded packages.

And you are right, I'll commit this change on salsa.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Unmerged commits

2b7041d... by Lucas Kanashiro

Update maintainer

935dc9f... by Lucas Kanashiro

Update changelog

6aafdfe... by Lucas Kanashiro

Set no_proxy correctly when running autopkgtest (LP: #1885760)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 1b5f408..5e08cc3 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+ruby-webmock (3.8.3-1ubuntu1) groovy; urgency=medium
7+
8+ * Set no_proxy correctly when running autopkgtest (LP: #1885760)
9+
10+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Tue, 30 Jun 2020 15:13:27 -0300
11+
12 ruby-webmock (3.8.3-1) unstable; urgency=medium
13
14 * Team upload
15diff --git a/debian/control b/debian/control
16index 1721aa0..72563ee 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -1,7 +1,8 @@
20 Source: ruby-webmock
21 Section: ruby
22 Priority: optional
23-Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
26 Uploaders: Pirate Praveen <praveen@debian.org>
27 Build-Depends: debhelper-compat (= 12),
28 gem2deb (>= 1),
29diff --git a/debian/ruby-tests.rake b/debian/ruby-tests.rake
30index 34a594b..77470d6 100644
31--- a/debian/ruby-tests.rake
32+++ b/debian/ruby-tests.rake
33@@ -3,6 +3,13 @@ require "rspec"
34
35 ENV["NO_CONNECTION"]="true"
36
37+# Some tests rely on http://0.0.0.0 and they fail in Ubuntu autopkgtest env.
38+if ENV["AUTOPKGTEST_TMP"]
39+ if ENV["no_proxy"]
40+ ENV["no_proxy"] += ",0.0.0.0"
41+ end
42+end
43+
44 RSpec::Core::RakeTask.new(:spec) do |t|
45 t.rspec_opts = ["-c", "-f progress", "-r ./spec/spec_helper.rb"]
46 t.pattern = FileList["spec/**/*_spec.rb"].exclude("spec/acceptance/patron/*").exclude('spec/quality_spec.rb').exclude('spec/acceptance/async_http_client/*').exclude('spec/acceptance/excon/excon_spec.rb').exclude('spec/acceptance/http_rb/http_rb_spec.rb')

Subscribers

People subscribed via source and target branches

to all changes: