Merge lp:~luc-demeyer/openobject-addons/7.0-partner-accounting-fix into lp:openobject-addons/7.0

[Luc De Meyer (Noviat)]

This module fixes an inconsistency between the way OpenERP 7.0 treats the partner accounting parameters :
• For invoices, the accounts payable/receivable of the partner ‘company’ record (if any) is used (which is the right way)
• For other accounting parameters (e.g. VAT number, payment terms, ... ) the partner ‘contact’ record is used (hence : 10 contacts within the same partner company may have 10 different VAT numbers … ).

How to use functionality offered by this fix e.g. have a look to the account_invoice.py

Line 23 : from openerp.addons.partner_accounting_fix.accounting_partner import accounting_partner
Line 31: partner = accounting_partner(partner) # replace by the partner for which the accounting entries will be created

So basically : 2 lines of code, 5 minutes of work and the whole thing becomes consistent (but these 5 minutes are required in all modules which retrieve partner accounting parameters).

Please merge the 'partner_accounting_fix’ functionality into the OpenERP standard V7.0 distribution.

Unmerged revisions

8724. By openerp <openerp@oerp70> on 2013-02-18

fix inconsistency in partner accounting parameters

=== added directory 'partner_accounting_fix'
=== added file 'partner_accounting_fix/__init__.py'
--- partner_accounting_fix/__init__.py	1970-01-01 00:00:00 +0000
+++ partner_accounting_fix/__init__.py	2013-02-18 21:59:22 +0000
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.be). All rights reserved.
+# 
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import account_invoice
\ No newline at end of file

=== added file 'partner_accounting_fix/__openerp__.py'
--- partner_accounting_fix/__openerp__.py	1970-01-01 00:00:00 +0000
+++ partner_accounting_fix/__openerp__.py	2013-02-18 21:59:22 +0000
@@ -0,0 +1,42 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.be). All rights reserved.
+# 
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Partner Account Properties fixes',
+    'version': '0.1',
+    'license': 'AGPL-3',
+    'author': 'Noviat',
+    'category' : 'Generic Modules',
+    'description': """
+    
+    Hide accounting fields on partner 'contact' records.
+    This equires also a change of legal reports (e.g. invoice to retrieve the VAT number from the parent record).
+        
+    """,
+    'depends': ['account'],
+    'demo_xml': [],
+    'init_xml': [],
+    'update_xml' : [
+        'res_partner_view.xml',
+    ],
+    'auto_install': True,
+    }

=== added file 'partner_accounting_fix/account_invoice.py'
--- partner_accounting_fix/account_invoice.py	1970-01-01 00:00:00 +0000
+++ partner_accounting_fix/account_invoice.py	2013-02-18 21:59:22 +0000
@@ -0,0 +1,35 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.be). All rights reserved.
+# 
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import osv, fields
+from openerp.addons.partner_accounting_fix.accounting_partner import accounting_partner
+
+class account_invoice(osv.osv):
+    _inherit = 'account.invoice'
+
+    def onchange_partner_id(self, cr, uid, ids, type, partner_id,\
+            date_invoice=False, payment_term=False, partner_bank_id=False, company_id=False):
+        partner = self.pool.get('res.partner').browse(cr, uid, partner_id)
+        partner = accounting_partner(partner) # replace by partner for which the accounting entries will be created
+        return super(account_invoice, self).onchange_partner_id(cr, uid, ids, type, partner.id,   \
+            date_invoice, payment_term, partner_bank_id, company_id)
+

=== added file 'partner_accounting_fix/accounting_partner.py'
--- partner_accounting_fix/accounting_partner.py	1970-01-01 00:00:00 +0000
+++ partner_accounting_fix/accounting_partner.py	2013-02-18 21:59:22 +0000
@@ -0,0 +1,29 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.be). All rights reserved.
+# 
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+def accounting_partner(partner):
+    """
+    Returns the partner for which the accounting entries will be created.
+    """
+    if partner.parent_id and not partner.is_company:
+        partner = partner.parent_id
+    return partner

=== added file 'partner_accounting_fix/res_partner_view.xml'
--- partner_accounting_fix/res_partner_view.xml	1970-01-01 00:00:00 +0000
+++ partner_accounting_fix/res_partner_view.xml	2013-02-18 21:59:22 +0000
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+  <data>
+
+    <!-- hide accounting fields for 'contact' partners records -->
+    <record id="view_partner_form_fix" model="ir.ui.view">
+      <field name="name">res.partner.vat.fix</field>
+      <field name="model">res.partner</field>
+      <field name="inherit_id" ref="account.view_partner_property_form"/>
+      <field name="arch" type="xml">
+        <xpath expr="//page[@string='Accounting']" position="attributes">
+          <attribute name="attrs">{'invisible':[('is_company','=',False),('parent_id','!=',False)]}</attribute>
+        </xpath>
+      </field>
+    </record>
+
+  </data>
+</openerp>
+