Code review comment for lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes

Revision history for this message
Luc De Meyer (Noviat) (luc-demeyer) wrote :

I have splitted the merge into three separate merge proposals in order to facilitate the review.

1) dutch translations

     Cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats/+merge/193704

2) General Ledger should include accounting move lines in close & opening periods

      Cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709

3) Add support for customers who start to use OpenERP accounting after one of more years of using OpenERP for other purposes by changing the '_get_first_special_period' logic.

     Cf. https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717

Regards,
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Maxime Chambreuil (http://www.savoirfairelinux.com)
Sent: zondag 3 november 2013 15:50
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes into lp:account-financial-report

Review: Disapprove

Luc,

Please refer to the community guidelines to get your contributions merged:
https://doc.openerp.com/contribute/15_guidelines/contribution_guidelines/#merge-proposal-guidelines

"Work on a separate feature/bug/whatever at a time. Do not mix lots of changes in one merge proposal, as it will be too complicated to review, thus refused."
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes/+merge/172359
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-fixes.

« Back to merge proposal