Code review comment for lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2

Revision history for this message
Luc De Meyer (Noviat) (luc-demeyer) wrote :

The account_financial_report_webkit module needs to know only the very first special period from where accounting is being done in OpenERP (with accounting I mean full accounting, not just payables/receivables).
From that first special period, the opening balances for all the fiscal years on which we need to financial reports are calculated correctly.
Hence only one parameter at the company level is required.

Regards,
Luc

www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Pedro Manuel Baeza
Sent: zaterdag 7 juni 2014 12:16
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report

Review: Needs Information code review

Hi, Luc,

I see your solution very restricted, because you can have an special period for each fiscal year. Setting it at company level doesn't seem the best approach. Why don't you put it at fiscal year level?

Regards.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2.

« Back to merge proposal