Code review comment for lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix

The problem is that you have many OpenERP systems out there which have been used for years for other purposes than accounting.
During those years, accounting entries have been generated but these entries were only used for e.g. one department or only sale/purchase of goods, ...
Real reconciliations in those systems are usually done outside OpenERP (in the accounting software).

Hence the partner data in those years are incorrect and the reports should start from the point where a first correct opening balance has been uploaded, not the first year with (incorrect) accounting entries.

The MP is a potential way to handle this : we assume that there is no opening period as long as the system is not used for full accounting purposes.
In most cases where we added accounting to legacy OpenERP systems, this was the case (but not always).
Another way to tackle this issue is to add a configuration parameter to the 'company' settings to indicate what the first special period is.

Regards,
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Guewen Baconnier @ Camptocamp
Sent: maandag 4 november 2013 10:01
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

Review: Needs Fixing

Hi,

Thanks for the proposal.

While I understand the logic you want to change I don't understand what problem you want to fix (I could maybe guess but I'm not sure).
The code you propose was the same and we had to replace it by the more convoluted version that you want to replace.

This method is used by the partner reports (computation of the initial balance) and we need to find the opening period of the "first year _with_ accounting entries". We want the balance of the very first opening period. If we just search by date, we may find an opening period on a year which has not been used for the accounting => balance would be mistakenly 0.

--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix.