Code review comment for lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix

There is no bug report since imho the 'Description of Change' is clear : "General Ledger should include accounting move lines in close & opening periods."
Without this fix, you don't get a complete history of all moves in a certain fiscal year.

Regards,
Luc

www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Yannick Vaucher @ Camptocamp
Sent: vrijdag 31 januari 2014 10:48
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix into lp:account-financial-report

Review: Needs Information

Is there a bug report about this issue?
If it does can you link it?
If not can you create it?

l.64 + l.81 + l.104 + l.110 + l.114

Just a note about credits, your user name will be in the commit if someone really wants to know who wrote a specific line of code for exemple with bzr blame.

If you want to show you contributed to a module, please only add this in __openerp__.py under Contributors in description. It will even be better for your Company as it will be visible on apps.openerp.com and not only hidden somewhere in the code.

https://doc.openerp.com/contribute/05_developing_modules/#modules-description

Here is an exemple

http://bazaar.launchpad.net/~stock-logistic-core-editors/carriers-deliveries/7.0/view/head:/base_delivery_carrier_label/__openerp__.py

--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix.