lp:~lubuntu-dev/lxde/lxqt-panel

Created by Julien Lavergne and last modified
Get this branch:
bzr branch lp:~lubuntu-dev/lxde/lxqt-panel

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Lubuntu Developers
Project:
LXDE
Status:
Development

Import details

Import Status: Failed

This branch is an import of the HEAD branch of the Git repository at https://github.com/lxde/lxqt-panel.git.

The import has been suspended because it failed 5 or more times in succession.

Last successful import was .

Import started on russkaya and finished taking 20 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log

Recent revisions

1288. By Tsu Jan

Set the initial task button text (and icon) correctly (#454)

Fixes https://github.com/lxde/lxqt/issues/1303.

Detailed explanation:

When a window shows up, the signal `KWindowSystem::stackingOrderChanged` is emitted *before* `KWindowSystem::windowAdded`. The former signal is connected to the function `LXQtTaskBar::refreshTaskList()`, which calls the functions `LXQtTaskBar::addWindow()` and `LXQtTaskBar::removeWindow()` to add and remove monitored windows.

Connecting `LXQtTaskBar::refreshTaskList()` to the signal `KWindowSystem::stackingOrderChanged` not only is redundant but also causes a problem:

(1) It's redundant because the job of adding *new* windows should be done by `LXQtTaskBar::onWindowAdded()` connected to the signal `KWindowSystem::windowAdded`. However, with the current code, `LXQtTaskBar::addWindow()` is never called by that function because the new window is already added through `KWindowSystem::stackingOrderChanged`. Similarly, `LXQtTaskBar::onWindowRemoved()` should be responsible for removing windows by being connected to the signal `KWindowSystem::windowRemoved`.

(2) More importantly, as the window name can change in the short interval between the emissions of `KWindowSystem::stackingOrderChanged` and `KWindowSystem::windowAdded`, the corresponding taskbar button may get a wrong text. The reason is that the signal `WindowSystem::windowChanged` announces changes only starting from the emission of `KWindowSystem::windowAdded`. (Theoretically, the initial icon might also be wrong but that's rarer).

Here, the connection to `KWindowSystem::stackingOrderChanged` is removed, so that the initial task button text/icon is set correctly. In this way, several useless calls to `LXQtTaskBar::refreshTaskList()` are also prevented when a window is shown/closed or focused/unfocused.

1287. By notname000 <email address hidden>

Update Simplified Chinese translations (#456)

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Add Simplified Chinese translations

* Update networkmonitor_zh_CN.desktop

1286. By Balló György

Fix worldclock in panel.conf

This fixes the change introduced in a014248fdc9fbbd0972fb44b8b5d1776301a889b

1285. By Tsu Jan

Move and Resize items in task-button context menu

Fixes https://github.com/lxde/lxqt/issues/1434.

1284. By Alf Gaida

Drop missed foreach

1283. By Luís Pereira

Prevent possible container detachments

Deep copies are expensive and not needed here.

1282. By Luís Pereira

Drop Qt foreach

Replaced by the ranged-based for loop.
Qt 5.7.1 is required. We use qAsConst().
The replacement brings some performance improvements. Container detachments
and container anti-pattern use were fixed.

1281. By comicfans <email address hidden>

avoid infinite recursion when no icon avaible.

1280. By Alf Gaida

pavucontrol should be pavucontrol-qt

fixes lxde/lxqt/issues/1421

1279. By palinek

cpuload: Do proper cleanup

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.