lp:~lttng/babeltrace/trunk

Created by Ubuntu LTTng on 2011-05-21 and last modified on 2019-10-17
Get this branch:
bzr branch lp:~lttng/babeltrace/trunk

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Ubuntu LTTng
Project:
Babeltrace
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://git.efficios.com/babeltrace.git.

The next import is scheduled to run in 1 hour.

Last successful import was 4 hours ago.

Import started 4 hours ago on alnitak and finished 4 hours ago taking 20 seconds — see the log
Import started 10 hours ago on izar and finished 10 hours ago taking 20 seconds — see the log
Import started 16 hours ago on alnitak and finished 16 hours ago taking 20 seconds — see the log
Import started 22 hours ago on izar and finished 22 hours ago taking 20 seconds — see the log
Import started on 2019-10-17 on izar and finished on 2019-10-17 taking 20 seconds — see the log
Import started on 2019-10-17 on izar and finished on 2019-10-17 taking 15 seconds — see the log
Import started on 2019-10-17 on izar and finished on 2019-10-17 taking 20 seconds — see the log
Import started on 2019-10-16 on alnitak and finished on 2019-10-16 taking 20 seconds — see the log
Import started on 2019-10-16 on alnitak and finished on 2019-10-16 taking 20 seconds — see the log
Import started on 2019-10-16 on izar and finished on 2019-10-16 taking 15 seconds — see the log

Recent revisions

3858. By Simon Marchi <email address hidden> on 2019-10-17

Fix: avoid double-free in build_index_from_idx_file

If the validation at the end of build_index_from_idx_file fails, the
index_entry variable will still point to the last processed index entry.
That same entry will also have been added to the index->entries array.

In the error path, we free index_entry and the index object, which frees
that index entry twice.

Fix it by clearing index_entry after adding the entry to the index
object (the ownership is conceptually transferred).

I don't add a test with this patch, because the file that triggers this
bug now hits a bug further in the processing. That file will be added
in the testsuite when it will no longer make babeltrace crash.

Change-Id: I091785895541105273c5d07d49f35628c2682e30
Signed-off-by: Simon Marchi <email address hidden>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2211
Reviewed-by: Francis Deslauriers <email address hidden>
CI-Build: Francis Deslauriers <email address hidden>
Tested-by: jenkins <email address hidden>

3857. By Francis Deslauriers <email address hidden> on 2019-10-17

Fix: ctf: query.c: Unchecked fclose() return value

Coverity report:
  CID 1382583 (#1 of 1): Unchecked return value (CHECKED_RETURN)12.
  check_return: Calling fclose without checking return value (as is done
  elsewhere 9 out of 11 times).

Reported-by: Coverity (1382583) Unchecked return value
Signed-off-by: Francis Deslauriers <email address hidden>
Change-Id: Ic5f7d46992b823bcb0571853da4ca23dcefe3d35
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2207
CI-Build: Jonathan Rajotte Julien <email address hidden>
Tested-by: jenkins <email address hidden>
Reviewed-by: Simon Marchi <email address hidden>

3856. By Simon Marchi <email address hidden> on 2019-10-16

Bump required glib version to 2.28

While investigating a hang in the lttng-live source component when
running with glib 2.22.5, we have found that this version had a bug in
g_ptr_array_remove_index_fast. When removing the last element of the
array, the free func is not called.

It was fixed in the following commit:

https://github.com/GNOME/glib/commit/5fffa39b6ae8f8faf1036fbf07de02ffe84ef099

The first major release where this is fixed is 2.26. We went through
the platforms we need to support, and the oldest glib version we need to
support is 2.28.6, on Solaris 11. Therefore, fix the issue with
lttng-live by bumping the required glib version to 2.28.

Change-Id: Ib56ac221dfc5ecf45eb62b837fe0b6f54032cf31
Signed-off-by: Simon Marchi <email address hidden>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2210
Reviewed-by: Michael Jeanson <email address hidden>
Reviewed-by: Jonathan Rajotte Julien <email address hidden>
Tested-by: jenkins <email address hidden>

3855. By Simon Marchi <email address hidden> on 2019-10-16

tests: test eq and ne operators of fields and values against arbitrary objects and None

The binary operator tests that test comparing fields and values against
arbitrary objects and None are skipped for the eq and ne operators.
This patch modifies the tests to test those operators too. Unlike other
operators, we don't expect them to raise an Exception.

Change-Id: Ia5f3c64d8223addc436ac23909e36f81814befee
Signed-off-by: Simon Marchi <email address hidden>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2206
Tested-by: jenkins <email address hidden>
Reviewed-by: Francis Deslauriers <email address hidden>

3854. By Simon Marchi <email address hidden> on 2019-10-16

tests: test_field.py: enable tests using _test_binop_lhs_value_same

Tests using _test_binop_lhs_value_same, that make sure that using a
binary operator on a field doesn't change that field's value, are
currently disabled. The problem is this line, that tries to copy the
field:

    value_before = copy.copy(self._def)

Since we have removed everything related to copy of fields, this is
unsupported. However, the same test but for unary operators copies the
Python value instead. Change _test_binop_lhs_value_same to do the same.

It's not clear to me if copying the value is really necessary, but I
prefer to leave it like this at the moment.

Change-Id: Ib35cbb44c000293e7e8ba42c020b5ace649a268d
Signed-off-by: Simon Marchi <email address hidden>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2205
Tested-by: jenkins <email address hidden>
Reviewed-by: Francis Deslauriers <email address hidden>

3853. By .eepp on 2019-10-16

babeltrace2-intro(7): refer to `babeltrace2(1)` i/o `babeltrace2-convert(1)`

Signed-off-by: Philippe Proulx <email address hidden>
Change-Id: I3aafc3ca85d228ecb8c185871ab51bd5c25764f9

3852. By .eepp on 2019-10-16

babeltrace2-intro(7): add more changes since Babeltrace 1

Also: categorize the changes into general, CLI, CTF, LTTng live, and
library changes.

Signed-off-by: Philippe Proulx <email address hidden>
Change-Id: Ibbe9c52583d45aa0fce543da3691fcb7e82fe87f
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2209

3851. By Francis Deslauriers <email address hidden> on 2019-10-16

Cleanup: src.ctf.lttng-live: Dead assignment

scan-build report:
  Value stored to 'ret' is never read

Reported-by: Scan-Build - Dead assignment
Signed-off-by: Francis Deslauriers <email address hidden>
Change-Id: I9ee4163e6268cd96591723a5e4f04321fa86de2f
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2180
Tested-by: jenkins <email address hidden>
Reviewed-by: Simon Marchi <email address hidden>

3850. By Simon Marchi <email address hidden> on 2019-10-15

tests: remove test_ctf_writer_clock.py

Commit 0fd756a43bce605875565a14c1ed1b070fa3ad94 ("Remove everything
related to the `bt2.ctf_writer` Python module") removed the Python
bindings for the CTF writer.

A corresponding test is still there, but skipped. I think it can be
removed as well.

Change-Id: I04091a0bc3f04a87c01947956108d83006d9330b
Signed-off-by: Simon Marchi <email address hidden>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2204
Reviewed-by: Francis Deslauriers <email address hidden>
Tested-by: jenkins <email address hidden>

3849. By Francis Deslauriers <email address hidden> on 2019-10-15

Fix: flt.lttng-utils.debug-info: Dereference after null check

Coverity report:
  CID 1401218 (#1 of 1): Dereference after null check (FORWARD_NULL)
  4. var_deref_op: Dereferencing null pointer bin.

Reported-by: Coverity (1401218) Dereference after null check
Signed-off-by: Francis Deslauriers <email address hidden>
Change-Id: I1821a4f2e39096cb3dca75033ab9ce25f4b63127
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2167
Reviewed-by: Simon Marchi <email address hidden>
CI-Build: Simon Marchi <email address hidden>
Tested-by: jenkins <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers