Merge lp:~ltrager/maas/rack_commission_commands into lp:~maas-maintainers/maas/packaging

Proposed by Lee Trager
Status: Merged
Approved by: Lee Trager
Approved revision: no longer in the source branch.
Merged at revision: 437
Proposed branch: lp:~ltrager/maas/rack_commission_commands
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 33 lines (+7/-1)
2 files modified
debian/control (+5/-1)
debian/extras/99-maas-sudoers (+2/-0)
To merge this branch: bzr merge lp:~ltrager/maas/rack_commission_commands
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+282703@code.launchpad.net

Commit message

Allow user maas to sudo lshw and blockdev

Description of the change

In order to be able to run the commissioning scripts on the rack controller the user maas needs to be able to run lshw and blockdev as root.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

We have to make sure that the data here is stored exactly the same way as
how would a node would store it. This is because in the future Maas will be
deploying rack controllers!

On Friday, January 15, 2016, Lee Trager <email address hidden> wrote:

> Lee Trager has proposed merging lp:~ltrager/maas/rack_commission_commands
> into lp:~maas-maintainers/maas/packaging.
>
> Commit message:
> Allow user maas to sudo lshw and blockdev
>
> Requested reviews:
> MAAS Maintainers (maas-maintainers)
>
> For more details, see:
>
> https://code.launchpad.net/~ltrager/maas/rack_commission_commands/+merge/282703
>
> In order to be able to run the commissioning scripts on the rack
> controller the user maas needs to be able to run lshw and blockdev as root.
> --
> You are subscribed to branch lp:~maas-maintainers/maas/packaging.
>

--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

Revision history for this message
Blake Rouse (blake-rouse) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-12-20 21:21:02 +0000
3+++ debian/control 2016-01-15 22:04:58 +0000
4@@ -90,7 +90,9 @@
5 Package: python3-maas-provisioningserver
6 Section: python
7 Architecture: all
8-Depends: python3-bson,
9+Depends: archdetect-deb,
10+ lshw,
11+ python3-bson,
12 python3-crochet,
13 python3-curtin (>> 0.1.0~bzr275),
14 python3-distro-info,
15@@ -109,6 +111,8 @@
16 python3-txtftp,
17 python3-yaml,
18 python3-zope.interface,
19+ isc-dhcp-client,
20+ iproute2,
21 ${misc:Depends},
22 ${python3:Depends}
23 Breaks: maas-cluster-controller (<= 0.1+bzr1243+dfsg-0ubuntu3),
24
25=== modified file 'debian/extras/99-maas-sudoers'
26--- debian/extras/99-maas-sudoers 2015-05-22 12:08:34 +0000
27+++ debian/extras/99-maas-sudoers 2016-01-15 22:04:58 +0000
28@@ -10,3 +10,5 @@
29 maas ALL= NOPASSWD: /usr/sbin/service tgt start
30 maas ALL= NOPASSWD: /usr/sbin/maas-provision
31 maas ALL= NOPASSWD: SETENV: /usr/sbin/tgt-admin, /usr/bin/uec2roottar
32+maas ALL= NOPASSWD: /usr/bin/lshw
33+maas ALL= NOPASSWD: /sbin/blockdev

Subscribers

People subscribed via source and target branches