Merge ~ltrager/maas:lp1889788_2.7 into maas:2.7

[Lee Trager]

LP: #1889788 - Always communicate with IPMI BMC's at OPERATOR level.

While the ipmipower command defaults to using OPERATOR the
ipmi-chassis-config and ipmitool commands both default to ADMIN.
Specify that OPERATOR should be used for all IPMI commands.

Backport of c348e0c

[Lee Trager (ltrager)]

Approved in https://code.launchpad.net/~ltrager/maas/+git/maas/+merge/388511

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b lp1889788_2.7 lp:~ltrager/maas/+git/maas into -b 2.7 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8074/consoleText

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1889788_2.7 lp:~ltrager/maas/+git/maas into -b 2.7 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8076/console
COMMIT: f85c406354788c798dacd7c99b44e8847e661735

review: Needs Fixing

[Adam Collard (adam-collard)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1889788_2.7 lp:~ltrager/maas/+git/maas into -b 2.7 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: f85c406354788c798dacd7c99b44e8847e661735

review: Approve

diff --git a/src/provisioningserver/drivers/power/ipmi.py b/src/provisioningserver/drivers/power/ipmi.py
index 02d49a0..e99b807 100644
--- a/src/provisioningserver/drivers/power/ipmi.py
+++ b/src/provisioningserver/drivers/power/ipmi.py
@@ -1,4 +1,4 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2015-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """IPMI Power Driver."""
@@ -321,8 +321,16 @@ class IPMIPowerDriver(PowerDriver):
             "ipmi-chassis-config",
             "-W",
             "opensesspriv",
+            "-l",
+            "OPERATOR",
+        ]
+        ipmipower_command = [
+            "ipmipower",
+            "-W",
+            "opensesspriv",
+            "-l",
+            "OPERATOR",
         ]
-        ipmipower_command = ["ipmipower", "-W", "opensesspriv"]
 
         # Arguments in common between chassis config and power control. See
         # https://launchpad.net/bugs/1053391 for details of modifying the
diff --git a/src/provisioningserver/drivers/power/moonshot.py b/src/provisioningserver/drivers/power/moonshot.py
index c8f2bf5..b8877c2 100644
--- a/src/provisioningserver/drivers/power/moonshot.py
+++ b/src/provisioningserver/drivers/power/moonshot.py
@@ -1,4 +1,4 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2015-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Moonshot IPMI Power Driver."""
@@ -67,6 +67,8 @@ class MoonshotIPMIPowerDriver(PowerDriver):
             power_user,
             "-P",
             power_pass,
+            "-L",
+            "OPERATOR",
         ) + tuple(power_hwaddress.split())
         if power_change == "pxe":
             command += ("chassis", "bootdev", "pxe")
diff --git a/src/provisioningserver/drivers/power/seamicro.py b/src/provisioningserver/drivers/power/seamicro.py
index 7b5134d..18f5a7b 100644
--- a/src/provisioningserver/drivers/power/seamicro.py
+++ b/src/provisioningserver/drivers/power/seamicro.py
@@ -1,4 +1,4 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2015-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """SeaMicro Power Driver."""
@@ -83,6 +83,8 @@ class SeaMicroPowerDriver(PowerDriver):
                     username,
                     "-P",
                     password,
+                    "-L",
+                    "OPERATOR",
                     "raw",
                     "0x2E",
                     "1",
diff --git a/src/provisioningserver/drivers/power/tests/test_ipmi.py b/src/provisioningserver/drivers/power/tests/test_ipmi.py
index 7c34bba..3802d4c 100644
--- a/src/provisioningserver/drivers/power/tests/test_ipmi.py
+++ b/src/provisioningserver/drivers/power/tests/test_ipmi.py
@@ -1,4 +1,4 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2015-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Tests for `provisioningserver.drivers.power.ipmi`."""
@@ -53,6 +53,8 @@ def make_ipmi_chassis_config_command(
         ipmi_chassis_config,
         "-W",
         "opensesspriv",
+        "-l",
+        "OPERATOR",
         "--driver-type",
         power_driver,
         "-h",
@@ -80,6 +82,8 @@ def make_ipmipower_command(
         ipmipower,
         "-W",
         "opensesspriv",
+        "-l",
+        "OPERATOR",
         "--driver-type",
         power_driver,
         "-h",
diff --git a/src/provisioningserver/drivers/power/tests/test_moonshot.py b/src/provisioningserver/drivers/power/tests/test_moonshot.py
index f34879d..d315dda 100644
--- a/src/provisioningserver/drivers/power/tests/test_moonshot.py
+++ b/src/provisioningserver/drivers/power/tests/test_moonshot.py
@@ -1,4 +1,4 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2015-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Tests for `provisioningserver.drivers.power.ipmi`."""
@@ -45,6 +45,8 @@ def make_command(
         power_user,
         "-P",
         power_pass,
+        "-L",
+        "OPERATOR",
     ) + tuple(power_hwaddress.split())
 
 
diff --git a/src/provisioningserver/drivers/power/tests/test_seamicro.py b/src/provisioningserver/drivers/power/tests/test_seamicro.py
index a8532cd..1e803e2 100644
--- a/src/provisioningserver/drivers/power/tests/test_seamicro.py
+++ b/src/provisioningserver/drivers/power/tests/test_seamicro.py
@@ -1,4 +1,4 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2015-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Tests for `provisioningserver.drivers.power.seamicro`."""
@@ -85,6 +85,8 @@ class TestSeaMicroPowerDriver(MAASTestCase):
                     username,
                     "-P",
                     password,
+                    "-L",
+                    "OPERATOR",
                     "raw",
                     "0x2E",
                     "1",