Merge ~ltrager/maas:lp1870171_2_2.4 into maas:2.4

[Lee Trager]

Backport of c25d426 LP: #1870171 - Remove token associations when transferring ownership of a Node.

[Lee Trager (ltrager)]

Approved in https://code.launchpad.net/~ltrager/maas/+git/maas/+merge/382436

review: Approve

diff --git a/src/maasserver/models/tests/test_userprofile.py b/src/maasserver/models/tests/test_userprofile.py
index 1a9bdc3..5ae0af7 100644
--- a/src/maasserver/models/tests/test_userprofile.py
+++ b/src/maasserver/models/tests/test_userprofile.py
@@ -12,6 +12,7 @@ from maasserver.models import (
     UserProfile,
 )
 from maasserver.models.user import (
+    create_auth_token,
     GENERIC_CONSUMER,
     get_auth_tokens,
     SYSTEM_USERS,
@@ -138,12 +139,16 @@ class UserProfileTest(MAASServerTestCase):
 
     def test_transfer_resources(self):
         user = factory.make_User()
-        node = factory.make_Node(owner=user)
+        token = create_auth_token(user)
+        node = factory.make_Node(owner=user, token=token)
         ipaddress = factory.make_StaticIPAddress(user=user)
         iprange = factory.make_IPRange(user=user)
         new_user = factory.make_User()
         user.userprofile.transfer_resources(new_user)
-        self.assertEqual(reload_object(node).owner, new_user)
+        token.delete()
+        node = reload_object(node)
+        self.assertEqual(node.owner, new_user)
+        self.assertIsNone(node.token)
         self.assertEqual(reload_object(ipaddress).user, new_user)
         self.assertEqual(reload_object(iprange).user, new_user)
 
diff --git a/src/maasserver/models/userprofile.py b/src/maasserver/models/userprofile.py
index be6a208..31bb562 100644
--- a/src/maasserver/models/userprofile.py
+++ b/src/maasserver/models/userprofile.py
@@ -104,7 +104,10 @@ class UserProfile(CleanSave, Model):
         :type new_owner: maasserver.models.UserProfile
 
         """
-        self.user.node_set.update(owner=new_owner)
+        # LP:1870171 - Make sure the previous owners key isn't assoicated with
+        # any node. Nothing uses the token and in MAAS 2.8+ Node.token has
+        # been removed.
+        self.user.node_set.update(owner=new_owner, token=None)
         self.user.staticipaddress_set.update(user=new_owner)
         self.user.iprange_set.update(user=new_owner)