Merge ~ltrager/maas:lp1751946 into maas:master

[Lee Trager]

LP: #1751946 - Only cleanup ScriptSets of the same type.

c58d869... by Lee Trager on 2018-02-28

Fix lint

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1751946 lp:~ltrager/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: a796282548af873a1b781e910bbb86b9bc385b78

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1751946 lp:~ltrager/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: c58d869304f61c9afd7231c945a3a3032e6030c0

review: Approve

[Alberto Donato (ack)]

+1, lgtm

review: Approve

diff --git a/src/metadataserver/models/scriptset.py b/src/metadataserver/models/scriptset.py
index ad8f51b..1b9e674 100644
--- a/src/metadataserver/models/scriptset.py
+++ b/src/metadataserver/models/scriptset.py
@@ -178,7 +178,6 @@ class ScriptSetManager(Manager):
         # node's current_testing_script_set the UI will show an empty table and
         # the node-results API will not output any test results.
         if not script_set.scriptresult_set.exists():
-            script_set.delete()
             raise NoScriptsFound()
 
         self._clean_old(node, RESULT_TYPE.TESTING, script_set)
@@ -282,6 +281,7 @@ class ScriptSetManager(Manager):
         # it is not associated with any disk. Check for this case and clean it
         # up when trying commissioning again.
         for script_result in ScriptResult.objects.filter(
+                script_set__result_type=new_script_set.result_type,
                 script_set__node=node).exclude(parameters={}).exclude(
                     script_set=new_script_set):
             for param in script_result.parameters.values():
diff --git a/src/metadataserver/models/tests/test_scriptset.py b/src/metadataserver/models/tests/test_scriptset.py
index 3da10d6..82645de 100644
--- a/src/metadataserver/models/tests/test_scriptset.py
+++ b/src/metadataserver/models/tests/test_scriptset.py
@@ -18,6 +18,7 @@ from maasserver.models import (
     Config,
     Event,
     EventType,
+    Node,
 )
 from maasserver.preseed import CURTIN_INSTALL_LOG
 from maasserver.testing.factory import factory
@@ -371,6 +372,28 @@ class TestScriptSetManager(MAASServerTestCase):
                 1,
                 ScriptResult.objects.filter(script_name=script_name).count())
 
+    def test_create_commissioning_script_set_only_cleans_same_type(self):
+        # Regression test for LP:1751946
+        node = Node.objects.create()
+        script_set = ScriptSet.objects.create_commissioning_script_set(
+            node=node)
+        script_set.scriptresult_set.update(status=SCRIPT_STATUS.ABORTED)
+        node.current_commissioning_script_set = script_set
+        script = factory.make_Script(
+            script_type=SCRIPT_TYPE.TESTING,
+            parameters={'storage': {'type': 'storage'}})
+        testing_script_set = ScriptSet.objects.create_testing_script_set(
+            node=node, scripts=[script.id])
+        testing_script_set.scriptresult_set.update(
+            status=SCRIPT_STATUS.ABORTED)
+        node.current_testing_script_set = testing_script_set
+        node.save()
+        new_script_set = ScriptSet.objects.create_commissioning_script_set(
+            node=node)
+        node.current_commissioning_script_set = new_script_set
+        node.save()
+        self.assertIsNotNone(ScriptSet.objects.get(id=testing_script_set.id))
+
     def test_create_commissioning_script_set_removes_previous_placeholder(
             self):
         # Regression test for LP:1731075