Code review comment for lp:~ltrager/flash-kernel/get_machine_deps

Revision history for this message
Scott Moser (smoser) wrote :

"I also confirmed check_supported isn't needed, get_machine_field will exit 1 if its not found."

Well, thats unfortunate.

What we want to have a program do is say : give me a list of packages that I shoudl install

and allow for that list to be "".

As I understand it right now, if the hardware should not install any, it will exit 1.

But then the caller cannot determine the differnce between failure for unexpected return
and "no packages to install".

Perhaps we then almost need a specific path for this.

Does that make sense ?

« Back to merge proposal