curtin

Merge ~ltrager/curtin:lp1881977 into curtin:master

  1. Git
  2. lp:~ltrager/curtin
  3. lp1881977
  4. Merge into master
Proposed by Lee Trager
Status: Merged
Approved by: Paride Legovini
Approved revision: bd2fe9450443bc94df731135de12d14bf38552e4
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~ltrager/curtin:lp1881977
Merge into: curtin:master
Diff against target: 16 lines (+5/-0)
1 file modified
curtin/commands/curthooks.py (+5/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Paride Legovini Approve
Review via email: mp+385079@code.launchpad.net

Commit message

LP: #1881977 - Install realpath on Trusty UEFI.

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

CI was not auto triggered in this MP as user ltrager is not in any allowed team. Now I'm manually tricking it into executing.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:bd2fe9450443bc94df731135de12d14bf38552e4
https://jenkins.ubuntu.com/server/job/curtin-ci/145/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/145/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/145/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/145/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/145/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/145//rebuild

review: Approve (continuous-integration)
Revision history for this message
Paride Legovini (paride) wrote :

LGTM

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/215/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/215/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/215/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/215/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/215/

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
2index d66afa7..11c718a 100644
3--- a/curtin/commands/curthooks.py
4+++ b/curtin/commands/curthooks.py
5@@ -1176,6 +1176,11 @@ def install_missing_packages(cfg, target, osfamily=DISTROS.debian):
6 # AMD64 has shim-signed for SecureBoot support
7 if arch == "amd64":
8 uefi_pkgs.append("shim-signed")
9+
10+ # realpath is part of coreutils in Xenial+, older versions need
11+ # the package to be installed.
12+ if not util.which("realpath"):
13+ uefi_pkgs.append("realpath")
14 else:
15 raise ValueError('Unknown grub2 package list for distro: %s' %
16 osfamily)

Subscribers

People subscribed via source and target branches