Merge lp:~louis/charms/precise/cinder/cinder-add-user-flags into lp:charms/raring/cinder

Proposed by Louis Bouchard
Status: Merged
Merged at revision: 28
Proposed branch: lp:~louis/charms/precise/cinder/cinder-add-user-flags
Merge into: lp:charms/raring/cinder
Diff against target: 47 lines (+13/-2)
4 files modified
config.yaml (+3/-0)
hooks/cinder_utils.py (+1/-0)
revision (+1/-1)
templates/cinder.conf (+8/-1)
To merge this branch: bzr merge lp:~louis/charms/precise/cinder/cinder-add-user-flags
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+201062@code.launchpad.net

Description of the change

Implements config-flags in the cinder charm as done in the nova-compute charm

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2013-10-22 23:11:16 +0000
3+++ config.yaml 2014-01-09 18:10:42 +0000
4@@ -115,3 +115,6 @@
5 ssl_key:
6 type: string
7 description: SSL key to use with certificate specified as ssl_cert.
8+ config-flags:
9+ type: string
10+ description: Comma separated list of key=value config flags to be set in cinder.conf.
11
12=== modified file 'hooks/cinder_utils.py'
13--- hooks/cinder_utils.py 2013-10-17 21:48:08 +0000
14+++ hooks/cinder_utils.py 2014-01-09 18:10:42 +0000
15@@ -100,6 +100,7 @@
16 'hook_contexts': [context.SharedDBContext(),
17 context.AMQPContext(),
18 context.ImageServiceContext(),
19+ context.OSConfigFlagContext(),
20 cinder_contexts.CephContext(),
21 cinder_contexts.HAProxyContext(),
22 cinder_contexts.ImageServiceContext()],
23
24=== modified file 'revision'
25--- revision 2013-10-17 21:48:08 +0000
26+++ revision 2014-01-09 18:10:42 +0000
27@@ -1,1 +1,1 @@
28-129
29+133
30
31=== modified file 'templates/cinder.conf'
32--- templates/cinder.conf 2013-10-22 23:11:16 +0000
33+++ templates/cinder.conf 2014-01-09 18:10:42 +0000
34@@ -41,4 +41,11 @@
35 {% endif -%}
36 {% if glance_api_version -%}
37 glance_api_version = {{ glance_api_version }}
38-{% endif -%}
39\ No newline at end of file
40+{% endif -%}
41+
42+{% if user_config_flags -%}
43+{% for key, value in user_config_flags.iteritems() -%}
44+{{ key }} = {{ value }}
45+{% endfor -%}
46+{% endif -%}
47+

Subscribers

People subscribed via source and target branches