Merge lp:~lore-mattei/onehundredscopes/shotwell-precise into lp:~davidc3/onehundredscopes/shotwell

Proposed by Lorenzo Mattei
Status: Merged
Merged at revision: 14
Proposed branch: lp:~lore-mattei/onehundredscopes/shotwell-precise
Merge into: lp:~davidc3/onehundredscopes/shotwell
Diff against target: 87 lines (+20/-31)
2 files modified
debian/control (+1/-1)
src/unity-scope-shotwell (+19/-30)
To merge this branch: bzr merge lp:~lore-mattei/onehundredscopes/shotwell-precise
Reviewer Review Type Date Requested Status
David Callé Pending
Review via email: mp+94523@code.launchpad.net

Description of the change

Message handling updated to Unity 5 interface.

To post a comment you must log in.
14. By David Callé

Now works on Precise. Thanks Lorenzo\!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2012-01-08 15:28:40 +0000
3+++ debian/control 2012-02-24 11:34:17 +0000
4@@ -17,7 +17,7 @@
5 Depends: ${shlibs:Depends},
6 ${misc:Depends},
7 ${python:Depends},
8- gir1.2-unity-4.0,
9+ gir1.2-unity-5.0,
10 gir1.2-dee-0.5,
11 python-lxml,
12 python-pyexiv2,
13
14=== modified file 'src/unity-scope-shotwell'
15--- src/unity-scope-shotwell 2012-01-12 08:54:19 +0000
16+++ src/unity-scope-shotwell 2012-02-24 11:34:17 +0000
17@@ -36,10 +36,8 @@
18 def __init__ (self):
19 self.scope = Unity.Scope.new ("/net/launchpad/scope/image/shotwell")
20 self.scope.search_in_global = False
21- self.scope.connect ("notify::active-search", self.on_search_changed)
22- self.scope.connect ("notify::active", self.on_search_changed)
23- self.scope.connect ("notify::active-global-search", self.on_global_search_changed)
24- self.scope.connect ("filters-changed", self.on_search_changed);
25+ self.scope.connect ("search-changed", self.on_search_changed)
26+ self.scope.connect ("filters-changed", self.on_search_changed)
27 self.scope.connect ("activate-uri", self.on_activate_uri);
28 self.scope.export()
29
30@@ -47,31 +45,22 @@
31 GLib.spawn_command_line_async("xdg-open %s" % uri.replace(' ', '\ '))
32 return Unity.ActivationResponse(handled=Unity.HandledType.HIDE_DASH, goto_uri='')
33
34-
35- def get_search_string (self):
36- search = self.scope.props.active_search
37- return search.props.search_string if search else None
38
39- def get_global_search_string (self):
40- search = self.scope.props.active_global_search
41- return search.props.search_string if search else None
42-
43- def on_search_changed (self, scope, param_spec=None):
44- search = self.get_search_string()
45- print "Search changed to: '%s'" % search
46- results = self.scope.props.results_model
47- results.clear()
48- self.update_results_model (search, results)
49- results.flush_revision_queue ()
50-
51- def on_global_search_changed (self, scope, param_spec=None):
52- search = self.get_global_search_string()
53- print "Global search changed to: '%s'" % search
54- results = self.scope.props.global_results_model
55- results.clear()
56- self.update_results_model (search, results)
57- results.flush_revision_queue ()
58-
59+ def on_search_changed (self, scope, search=None, search_type=0, cancellable=None):
60+ if search:
61+ search_string = search.props.search_string.strip()
62+ print "Search changed to: '%s'" %search_string
63+ else:
64+ search_string=''
65+ if search_type == Unity.SearchType.DEFAULT:
66+ model = self.scope.props.results_model
67+ else:
68+ model = self.scope.props.global_results_model
69+ model.clear()
70+ self.update_results_model (search_string, model)
71+ model.flush_revision_queue ()
72+ if search:
73+ search.finished()
74
75 def update_results_model(self, search, model):
76 date = self.check_filters("date")
77@@ -91,8 +80,8 @@
78 icon_hint = i[2]
79 model.append (uri, icon_hint, 1,"text/html", title, comment, uri)
80
81- if self.scope.props.active_search:
82- self.scope.props.active_search.emit("finished")
83+# if self.scope.props.active_search:
84+# self.scope.props.active_search.emit("finished")
85
86 def check_filters(self, filter_name):
87 try:

Subscribers

People subscribed via source and target branches

to all changes: