Merge lp:~lool/upstart/document-stop-in-pre-start into lp:upstart

Proposed by Loïc Minier
Status: Merged
Merged at revision: 1373
Proposed branch: lp:~lool/upstart/document-stop-in-pre-start
Merge into: lp:upstart
Diff against target: 47 lines (+18/-1)
2 files modified
init/man/init.5 (+4/-1)
util/man/initctl.8 (+14/-0)
To merge this branch: bzr merge lp:~lool/upstart/document-stop-in-pre-start
Reviewer Review Type Date Requested Status
James Hunt Approve
Upstart Developers Pending
Review via email: mp+95818@code.launchpad.net

Description of the change

Hey,

Wondered why documentation wasn't symmetric and also why stop/start without argument wasn't mentioned from their manpages, so submitting these proposed fixes.

Cheers,

To post a comment you must log in.
Revision history for this message
James Hunt (jamesodhunt) wrote :

Thanks Loïc - looks good.

review: Approve
Revision history for this message
Loïc Minier (lool) wrote :

I can't land this myself; would you be so kind to merge it into lp:upstart? (permission error when I try to do so myself)

Revision history for this message
James Hunt (jamesodhunt) wrote :

Done. Thanks again!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'init/man/init.5'
2--- init/man/init.5 2012-03-01 12:18:25 +0000
3+++ init/man/init.5 2012-03-04 23:36:31 +0000
4@@ -195,7 +195,10 @@
5 This process will be run after the job's
6 .BR starting (7)
7 event has finished, but before the main process is run. It is typically
8-used to prepare the environment, such as making necessary directories.
9+used to prepare the environment, such as making necessary directories,
10+and it may also call the
11+.BR stop (8)
12+command without arguments to cancel the start.
13 .\"
14 .TP
15 .B post\-start exec\fR|\fBscript\fR...
16
17=== modified file 'util/man/initctl.8'
18--- util/man/initctl.8 2012-02-16 15:45:41 +0000
19+++ util/man/initctl.8 2012-03-04 23:36:31 +0000
20@@ -139,6 +139,13 @@
21 If the job is already running,
22 .B start
23 will return an error.
24+
25+When called from the
26+.IR pre\-stop
27+stanza of a job configuration,
28+.B start
29+may be called without argument to cancel the
30+.B stop.
31 .\"
32 .TP
33 .B stop
34@@ -155,6 +162,13 @@
35 for a description of the output format and
36 .B start
37 for a discussion on instances.
38+
39+When called from the
40+.IR pre\-start
41+stanza of a job configuration,
42+.B stop
43+may be called without an argument to cancel the
44+.B start.
45 .\"
46 .TP
47 .B restart

Subscribers

People subscribed via source and target branches