Merge lp:~lool/qtpowerd/link-with-qtdbus into lp:~music-app-dev/qtpowerd/trunk

Proposed by Loïc Minier on 2013-09-30
Status: Merged
Approved by: David Planella on 2013-09-30
Approved revision: 4
Merged at revision: 4
Proposed branch: lp:~lool/qtpowerd/link-with-qtdbus
Merge into: lp:~music-app-dev/qtpowerd/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
qtpowerd.pro (+1/-1)
To merge this branch: bzr merge lp:~lool/qtpowerd/link-with-qtdbus
Reviewer Review Type Date Requested Status
David Planella Approve on 2013-09-30
Victor Thompson 2013-09-30 Approve on 2013-09-30
Ubuntu Phone Apps Jenkins Bot 2013-09-30 Pending
Review via email: mp+188350@code.launchpad.net

Commit message

Link with QtDBus as it uses some of its symbols; otherwise one gets:
/usr/lib/arm-linux-gnueabihf/qt5/bin/qmlscene: symbol lookup error: /usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Powerd.0.1/libqmlpowerdplugin.so: undefined symbol: _ZN15QDBusConnection9systemBusEv
(this is QDBusConnection::systemBus())

Description of the change

Link with QtDBus as it uses some of its symbols; otherwise one gets:
/usr/lib/arm-linux-gnueabihf/qt5/bin/qmlscene: symbol lookup error: /usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Powerd.0.1/libqmlpowerdplugin.so: undefined symbol: _ZN15QDBusConnection9systemBusEv
(this is QDBusConnection::systemBus())

To post a comment you must log in.
Victor Thompson (vthompson) wrote :

Thanks, I didn't know how to get past the undefined symbol error. I'll work on the plugin portion to figure out what's wrong with the property I'm defining.

review: Approve
Loïc Minier (lool) wrote :

Is autolanding setup for this lp:qtpowerd? If not, should it be setup? if you don't want it, I think you'll have to merge it, as I don't think I have access to lp:qtpowerd.

Victor Thompson (vthompson) wrote :

I thought that if I assigned the maintainer to Ubuntu Core Apps Drivers that I'd pick up autolanding--this may not be the case.

David Planella (dpm) wrote :

Branch autolanding is not enabled for this project yet, so merges need to be done manually.

Only daily builds for packages are enabled, so after the merge is done, the package will automatically be built.

Happy to take care of the merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qtpowerd.pro'
2--- qtpowerd.pro 2013-09-26 00:12:18 +0000
3+++ qtpowerd.pro 2013-09-30 14:46:27 +0000
4@@ -1,7 +1,7 @@
5 TEMPLATE = lib
6 CONFIG += qt plugin link_pkgconfig
7
8-equals(QT_MAJOR_VERSION, 5): QT = core qml
9+equals(QT_MAJOR_VERSION, 5): QT = core dbus qml
10
11 PKGCONFIG =
12

Subscribers

People subscribed via source and target branches

to all changes: