Merge lp:~lool/music-app/singleton into lp:music-app/trusty
Status: | Merged |
---|---|
Approved by: | Nicholas Skaggs |
Approved revision: | 128 |
Merged at revision: | 128 |
Proposed branch: | lp:~lool/music-app/singleton |
Merge into: | lp:music-app/trusty |
Diff against target: |
12 lines (+2/-1) 1 file modified
music-app.desktop (+2/-1) |
To merge this branch: | bzr merge lp:~lool/music-app/singleton |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Nicholas Skaggs (community) | Approve | ||
Review via email:
|
Commit message
Add X-Ubuntu-
Description of the change
Hi there,
The design goal for Touch apps is to have all Click and non-Click apps single instance. This branch adds a flag to achieve this in music-app.
Another goal I'm trying to get closer to is being able to play music:// URLs from the dash one after the other. Currently, the music-app stops when put in the background, but it will soon keep playing (next platform-api package update will whitelist music-app). Then it's critical for us to ensure that we don't start multiple music-app instances.
The longer term plan to load a new URL in a running app involves implementing a new DBus interface in apps which would automatically be provided by the SDK, but it's still some time away. In the mean time, we made upstart-app-launch kill the running app and start it again with the new URL.
The patch I'm proposing here tells upstart-app-launch to keep a single music-app instance around, we've merged it for other builtin apps.
NB: a fix for an upstart-app-launch bug, LP# 1229468, is also pending upload