Merge lp:~lool/music-app/singleton into lp:music-app/trusty

Proposed by Loïc Minier
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 128
Merged at revision: 128
Proposed branch: lp:~lool/music-app/singleton
Merge into: lp:music-app/trusty
Diff against target: 12 lines (+2/-1)
1 file modified
music-app.desktop (+2/-1)
To merge this branch: bzr merge lp:~lool/music-app/singleton
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs (community) Approve
Review via email: mp+187583@code.launchpad.net

Commit message

Add X-Ubuntu-Single-Instance=true and reorder X- fields alphabetically; X-Ubuntu-Single-Instance=true allows with recent upstart-app-launch versions to prevent multiple instances of the same app to be launched (Click or non-Click apps). This is useful to reuse a running a music-app instance to load a new music:// URL.

Description of the change

Hi there,

The design goal for Touch apps is to have all Click and non-Click apps single instance. This branch adds a flag to achieve this in music-app.

Another goal I'm trying to get closer to is being able to play music:// URLs from the dash one after the other. Currently, the music-app stops when put in the background, but it will soon keep playing (next platform-api package update will whitelist music-app). Then it's critical for us to ensure that we don't start multiple music-app instances.

The longer term plan to load a new URL in a running app involves implementing a new DBus interface in apps which would automatically be provided by the SDK, but it's still some time away. In the mean time, we made upstart-app-launch kill the running app and start it again with the new URL.

The patch I'm proposing here tells upstart-app-launch to keep a single music-app instance around, we've merged it for other builtin apps.

NB: a fix for an upstart-app-launch bug, LP# 1229468, is also pending upload

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'music-app.desktop'
2--- music-app.desktop 2013-09-23 22:16:39 +0000
3+++ music-app.desktop 2013-09-25 19:25:00 +0000
4@@ -8,6 +8,7 @@
5 Terminal=false
6 Type=Application
7 StartupNotify=true
8+X-Ubuntu-Single-Instance=true
9+X-Ubuntu-StageHint=music-app
10 X-Ubuntu-Touch=true
11-X-Ubuntu-StageHint=music-app
12 Name[sv_SE]=Musik

Subscribers

People subscribed via source and target branches

to status/vote changes: