Merge lp:~lool/linaro-image-tools/efikasb-support into lp:linaro-image-tools/11.11

Proposed by Loïc Minier
Status: Merged
Merged at revision: 300
Proposed branch: lp:~lool/linaro-image-tools/efikasb-support
Merge into: lp:linaro-image-tools/11.11
Diff against target: 111 lines (+35/-21)
2 files modified
linaro_media_create/boards.py (+30/-18)
linaro_media_create/tests/test_media_create.py (+5/-3)
To merge this branch: bzr merge lp:~lool/linaro-image-tools/efikasb-support
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) code Approve
Review via email: mp+53864@code.launchpad.net

Description of the change

Support for EfikaMX SmartBook and some related i.MX5x adjustments.

To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote :

Looks good to me.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_media_create/boards.py'
2--- linaro_media_create/boards.py 2011-03-10 23:28:21 +0000
3+++ linaro_media_create/boards.py 2011-03-17 17:53:40 +0000
4@@ -57,10 +57,11 @@
5 """Round value to the next multiple of align."""
6 return (value + align - 1) / align * align
7
8-# optional bootloader partition; at least 1 MiB; in theory, an i.MX5 bootloader
9-# partition could hold RedBoot, FIS table, RedBoot config, kernel, and initrd,
10-# but we typically use U-Boot which is about 167 KiB as of 2011/02/11 and
11-# currently doesn't even store its environment there, so this should be enough
12+# optional bootloader partition; at least 1 MiB; in theory, an i.MX5x
13+# bootloader partition could hold RedBoot, FIS table, RedBoot config, kernel,
14+# and initrd, but we typically use U-Boot which is about 167 KiB as of
15+# 2011/02/11 and currently doesn't even store its environment there, so this
16+# should be enough
17 LOADER_MIN_SIZE_S = align_up(1 * 1024 * 1024, SECTOR_SIZE) / SECTOR_SIZE
18 # boot partition; at least 50 MiB; XXX this shouldn't be hardcoded
19 BOOT_MIN_SIZE_S = align_up(50 * 1024 * 1024, SECTOR_SIZE) / SECTOR_SIZE
20@@ -417,10 +418,6 @@
21 serial_tty = 'ttymxc0'
22 extra_serial_opts = 'console=tty0 console=%s,115200n8' % serial_tty
23 live_serial_opts = 'serialtty=%s' % serial_tty
24- kernel_addr = '0x90000000'
25- initrd_addr = '0x90800000'
26- load_addr = '0x90008000'
27- kernel_suffix = 'linaro-mx51'
28 boot_script = 'boot.scr'
29 mmc_part_offset = 1
30 mmc_option = '0:2'
31@@ -465,22 +462,36 @@
32 make_boot_script(boot_env, boot_script)
33
34
35-class EfikamxConfig(Mx5Config):
36- uboot_flavor = 'efikamx'
37-
38-
39-class Mx51evkConfig(Mx5Config):
40- uboot_flavor = 'mx51evk'
41-
42-
43-class Mx53LoCoConfig(Mx5Config):
44- uboot_flavor = 'mx53loco'
45+class Mx51Config(Mx5Config):
46+ kernel_addr = '0x90000000'
47+ initrd_addr = '0x90800000'
48+ load_addr = '0x90008000'
49+ kernel_suffix = 'linaro-mx51'
50+
51+
52+class Mx53Config(Mx5Config):
53 kernel_addr = '0x70800000'
54 initrd_addr = '0x71800000'
55 load_addr = '0x70008000'
56 kernel_suffix = 'linaro-lt-mx53'
57
58
59+class EfikamxConfig(Mx51Config):
60+ uboot_flavor = 'efikamx'
61+
62+
63+class EfikasbConfig(Mx51Config):
64+ uboot_flavor = 'efikasb'
65+
66+
67+class Mx51evkConfig(Mx51Config):
68+ uboot_flavor = 'mx51evk'
69+
70+
71+class Mx53LoCoConfig(Mx53Config):
72+ uboot_flavor = 'mx53loco'
73+
74+
75 class VexpressConfig(BoardConfig):
76 uboot_flavor = 'ca9x4_ct_vxp'
77 uboot_in_boot_part = True
78@@ -589,6 +600,7 @@
79 'vexpress': VexpressConfig,
80 'ux500': Ux500Config,
81 'efikamx': EfikamxConfig,
82+ 'efikasb': EfikasbConfig,
83 'mx51evk': Mx51evkConfig,
84 'mx53loco' : Mx53LoCoConfig,
85 'overo': OveroConfig,
86
87=== modified file 'linaro_media_create/tests/test_media_create.py'
88--- linaro_media_create/tests/test_media_create.py 2011-03-12 09:31:11 +0000
89+++ linaro_media_create/tests/test_media_create.py 2011-03-17 17:53:40 +0000
90@@ -259,7 +259,9 @@
91 self.assertEqual(expected, self.funcs_calls)
92
93 def test_mx5_steps(self):
94- self.make_boot_files(boards.Mx51evkConfig)
95+ class SomeMx5Config(boards.Mx5Config):
96+ uboot_flavor = 'uboot_flavor'
97+ self.make_boot_files(SomeMx5Config)
98 expected = [
99 'install_mx5_boot_loader', 'make_uImage', 'make_uInitrd',
100 'make_boot_script']
101@@ -416,8 +418,8 @@
102 'bootm 0x60008000 0x81000000'}
103 self.assertEqual(expected, boot_commands)
104
105- def test_mx5(self):
106- boot_commands = boards.Mx5Config._get_boot_env(
107+ def test_mx51(self):
108+ boot_commands = boards.Mx51Config._get_boot_env(
109 is_live=False, is_lowmem=False, consoles=[],
110 rootfs_uuid="deadbeef")
111 expected = {

Subscribers

People subscribed via source and target branches