Merge lp:~lool/libubuntuone/out-of-tree-keyfile-lp-688538 into lp:libubuntuone

[Loïc Minier]

[dobey (dobey)]

This seems like the wrong way to solve the problem. I'm sure it works as a quick fix to the package itself, but we should make this more robust in the upstream source, and add a test to ensure the signing actually works during distcheck.

review: Disapprove

[dobey (dobey)]

I've filed a separate bug against libubuntuone for the more specific srcdir != builddir issue. I've also made a more robust fix and proposed it in https://code.edge.launchpad.net/~dobey/libubuntuone/srcdir-signing/+merge/43668 so I'm going to mark this as rejected in favor of that implementation instead. Thanks.

Unmerged revisions

111. By Loïc Minier on 2010-12-14

bindings/mono/Makefile.am: if srcdir != builddir, copy mono.snk keyfile
into builddir and pass $(srcdir)/*.cs to gmcs as to include
AssemblyInfo.cs and hence properly sign the DLL; LP: #688538.

=== modified file 'bindings/mono/Makefile.am'
--- bindings/mono/Makefile.am	2010-08-25 18:35:07 +0000
+++ bindings/mono/Makefile.am	2010-12-14 14:22:04 +0000
@@ -17,7 +17,12 @@
 ubuntuonesharp_DATA = ubuntuone-sharp.dll ubuntuone-sharp.dll.config
 
 ubuntuone-sharp.dll: U1MusicStore.cs
-	$(MONO_CSC) -target:library -pkg:gtk-sharp-2.0 -out:ubuntuone-sharp.dll *.cs
+	if [ "$(srcdir)" = "$(builddir)" ]; then \
+	    $(MONO_CSC) -target:library -pkg:gtk-sharp-2.0 -out:ubuntuone-sharp.dll *.cs; \
+	else \
+	    cp -f $(srcdir)/mono.snk .; \
+	    $(MONO_CSC) -target:library -pkg:gtk-sharp-2.0 -out:ubuntuone-sharp.dll *.cs $(srcdir)/*.cs; \
+	fi
 
 U1MusicStore.cs: ubuntuone-api.xml
 	$(MONO_GAPI_CODEGEN) --outdir=. $(GTKSHARP_CFLAGS) --generate $<