Merge lp:~lool/lava-dispatcher/add-unittest-for-config into lp:~qzhang/lava-dispatcher/remove-hardcode

[Loïc Minier]

I don't actually think we should test static config data, but this gives you a sample testing framework.

You don't need it to run the tests, but a helpful helper is "testr" in the testrepository package; run it with "testr init" and "testr run".

To run the tests manually, use:
python -m testtools.run lava.tests.test_suite

[Spring Zhang (qzhang)]

Thanks for the unit test sample. I run it successfully.

1. After I run "sudo pip install testtools --upgrade", I still got error:
  File "/usr/local/lib/python2.6/dist-packages/subunit/run.py", line 26, in <module>
    from testtools.run import (
ImportError: cannot import name BUFFEROUTPUT
id: 0 tests: 0

But I do "sudo apt-get install python-testtools", it works, what's the difference between pip-install and apt-get?

2. And when I do "testr delete", I got error:
Traceback (most recent call last):
  File "/usr/bin/testr", line 26, in <module>
    sys.exit(run_argv(sys.argv, sys.stdin, sys.stdout, sys.stderr))
  File "/usr/lib/python2.6/dist-packages/testrepository/commands/__init__.py", line 194, in run_argv
    cmdclass = _find_command(cmd_name)
  File "/usr/lib/python2.6/dist-packages/testrepository/commands/__init__.py", line 48, in _find_command
    raise KeyError("Could not import command module %s" % modname)
KeyError: 'Could not import command module testrepository.commands.delete'

[Spring Zhang (qzhang)]

review: Approve

[Loïc Minier (lool)]

On Thu, Mar 03, 2011, Spring Zhang wrote:
> 1. After I run "sudo pip install testtools --upgrade", I still got error:
> File "/usr/local/lib/python2.6/dist-packages/subunit/run.py", line 26, in <module>
> from testtools.run import (
> ImportError: cannot import name BUFFEROUTPUT
> id: 0 tests: 0
>
> But I do "sudo apt-get install python-testtools", it works, what's the difference between pip-install and apt-get?

 In general, it's a good idea to either ALWAYS use pip or NEVER use pip.
 I NEVER use pip because I don't want to mix Python modules coming from
 Ubuntu with modules installed locally. I recommend you remove all
 manually installed modules and just use the packaged versions as long
 as possible.

> 2. And when I do "testr delete", I got error:
> Traceback (most recent call last):
> File "/usr/bin/testr", line 26, in <module>
> sys.exit(run_argv(sys.argv, sys.stdin, sys.stdout, sys.stderr))
> File "/usr/lib/python2.6/dist-packages/testrepository/commands/__init__.py", line 194, in run_argv
> cmdclass = _find_command(cmd_name)
> File "/usr/lib/python2.6/dist-packages/testrepository/commands/__init__.py", line 48, in _find_command
> raise KeyError("Could not import command module %s" % modname)
> KeyError: 'Could not import command module testrepository.commands.delete'

 I don't know where this comes from. I suspect it's also a pip thing.

--
Loïc Minier

[Loïc Minier (lool)]

On Thu, Mar 03, 2011, Spring Zhang wrote:
> Review: Approve

 This is a mp request for your own branch, so you can just proceed to
 merging it to your branch if you like; I can't :-)

--
Loïc Minier

=== added file '.testr.conf'
--- .testr.conf	1970-01-01 00:00:00 +0000
+++ .testr.conf	2011-03-03 15:25:13 +0000
@@ -0,0 +1,3 @@
+[DEFAULT]
+test_command=python -m subunit.run $IDLIST
+test_id_list_default=lava.tests.test_suite

=== added directory 'lava/tests'
=== added file 'lava/tests/__init__.py'
--- lava/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ lava/tests/__init__.py	2011-03-03 15:25:13 +0000
@@ -0,0 +1,6 @@
+import unittest
+
+def test_suite():
+    module_names = ['lava.tests.test_config',]
+    loader = unittest.TestLoader()
+    return loader.loadTestsFromNames(module_names)

=== added file 'lava/tests/test_config.py'
--- lava/tests/test_config.py	1970-01-01 00:00:00 +0000
+++ lava/tests/test_config.py	2011-03-03 15:25:13 +0000
@@ -0,0 +1,22 @@
+from unittest import TestCase
+from lava.config import BOARD_CFG, LAVA_SERVER_CFG
+
+class TestConfigData(TestCase):
+    def test_beaglexm01_uboot_cmds(self):
+        expected = [
+            "mmc init",
+            "setenv bootcmd 'fatload mmc 0:3 0x80000000 uImage; fatload mmc "
+                "0:3 0x81600000 uInitrd; bootm 0x80000000 0x81600000'",
+            "setenv bootargs ' console=tty0 console=ttyO2,115200n8 "
+                "root=LABEL=testrootfs rootwait ro earlyprintk fixrtc "
+                "nocompcache vram=12M omapfb.debug=y "
+                "omapfb.mode=dvi:1280x720MR-16@60'",
+            "boot"]
+        board_type = BOARD_CFG.BOARD_TYPE["beaglexm01"]
+        uboot_cmds = BOARD_CFG.BOARDS_UBOOT[board_type]
+        self.assertEquals(expected, uboot_cmds)
+
+    def test_server_ip(self):
+        expected = "192.168.1.10"
+        self.assertEqual(expected, LAVA_SERVER_CFG.IP)
+