work-items-tracker

Merge lp:~lool/launchpad-work-items-tracker/needs-attention-escaping into lp:~linaro-automation/launchpad-work-items-tracker/linaro

  1. needs-attention-escaping
  2. Merge into linaro
Proposed by Loïc Minier
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 341
Merged at revision: 342
Proposed branch: lp:~lool/launchpad-work-items-tracker/needs-attention-escaping
Merge into: lp:~linaro-automation/launchpad-work-items-tracker/linaro
Diff against target: 12 lines (+1/-1)
1 file modified
templates/roadmap_lane.html (+1/-1)
To merge this branch: bzr merge lp:~lool/launchpad-work-items-tracker/needs-attention-escaping
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+118743@code.launchpad.net

Description of the change

Should fix "<font>Needs attention</font>" appearing as escaped HTML entities on the main page; this is my first usage of mako though, so another pair of eyes is welcome. I took documentation from: http://docs.makotemplates.org/en/latest/filtering.html

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks good to my eyes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/roadmap_lane.html'
2--- templates/roadmap_lane.html 2012-01-17 11:56:35 +0000
3+++ templates/roadmap_lane.html 2012-08-08 13:02:10 +0000
4@@ -43,7 +43,7 @@
5 </div>
6 </td>
7 <td>
8- ${'<font color="#FF0000">Needs attention!</font>' if not card_dict['card'].is_healthy else ''}
9+ ${'<font color="#FF0000">Needs attention!</font>' if not card_dict['card'].is_healthy else '' | n}
10 </td>
11 % endfor
12 % endfor

Subscribers

People subscribed via source and target branches