work-items-tracker

Merge lp:~lool/launchpad-work-items-tracker/meta-values-with-colons into lp:~linaro-automation/launchpad-work-items-tracker/linaro

  1. meta-values-with-colons
  2. Merge into linaro
Proposed by Loïc Minier
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 341
Merged at revision: 341
Proposed branch: lp:~lool/launchpad-work-items-tracker/meta-values-with-colons
Merge into: lp:~linaro-automation/launchpad-work-items-tracker/linaro
Diff against target: 12 lines (+1/-1)
1 file modified
collect (+1/-1)
To merge this branch: bzr merge lp:~lool/launchpad-work-items-tracker/meta-values-with-colons
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+118737@code.launchpad.net

Description of the change

Meta headers that contain a colon on the value side aren't parsed properly; this causes blueprints with "Headline: http://xyz" to be split as "Headline: http" as the header name instead of "Headline". Using split() instead of rsplit() fixes this just fine. Reported by Fathi Boudra.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Seems logical.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'collect'
2--- collect 2012-08-03 13:20:14 +0000
3+++ collect 2012-08-08 12:43:01 +0000
4@@ -152,7 +152,7 @@
5 return
6
7 try:
8- (key, value) = line.rsplit(':', 1)
9+ (key, value) = line.split(':', 1)
10 key = key.strip()
11 value = value.strip()
12 except ValueError:

Subscribers

People subscribed via source and target branches