Merge lp:~lool/click/14.10-framework into lp:click

Proposed by Loïc Minier
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~lool/click/14.10-framework
Merge into: lp:click
Diff against target: 64 lines (+28/-2)
2 files modified
click/chroot.py (+25/-0)
click/tests/test_framework.py (+3/-2)
To merge this branch: bzr merge lp:~lool/click/14.10-framework
Reviewer Review Type Date Requested Status
Colin Watson Needs Resubmitting
Review via email: mp+220581@code.launchpad.net

Description of the change

Add 14.10 framework in places where all frameworks are listed.

I didn't change all references of 14.04 such as documentation as 14.10 is still in development. We probably want to do this near the end of the cycle.

I've tested this with click chroot create -a amd64 (created saucy chroot) and click chroot create -a amd64 -f ubuntu-sdk-14.10, and both worked. Package builds and that runs the testsuite. NB: I did hit testsuite failures with -j4 but that's not a regression from this branch and they go away when I drop the -j4.

Cheers,

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

This basically looks fine to me, but could you please resubmit this against lp:click/devel, which we're using as the target for individual MPs now?

review: Needs Resubmitting
Revision history for this message
Loïc Minier (lool) wrote :

Unmerged revisions

427. By PS Jenkins bot

Releasing 0.4.23.1

426. By Michael Vogt

Click 0.4.23: handle framework removal, x86 chroot support, and various other small fixes. Fixes: 1271944, 1294659, 1296820, 1319153, 1320786

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click/chroot.py'
2--- click/chroot.py 2014-05-20 13:13:32 +0000
3+++ click/chroot.py 2014-05-22 08:39:06 +0000
4@@ -41,12 +41,19 @@
5 "ubuntu-sdk-14.04-html-dev1": "ubuntu-sdk-14.04",
6 "ubuntu-sdk-14.04-papi-dev1": "ubuntu-sdk-14.04",
7 "ubuntu-sdk-14.04-qml-dev1": "ubuntu-sdk-14.04",
8+ "ubuntu-sdk-14.04-html": "ubuntu-sdk-14.04",
9+ "ubuntu-sdk-14.04-papi": "ubuntu-sdk-14.04",
10+ "ubuntu-sdk-14.04-qml": "ubuntu-sdk-14.04",
11+ "ubuntu-sdk-14.10-html-dev1": "ubuntu-sdk-14.04",
12+ "ubuntu-sdk-14.10-papi-dev1": "ubuntu-sdk-14.04",
13+ "ubuntu-sdk-14.10-qml-dev1": "ubuntu-sdk-14.04",
14 }
15
16
17 framework_series = {
18 "ubuntu-sdk-13.10": "saucy",
19 "ubuntu-sdk-14.04": "trusty",
20+ "ubuntu-sdk-14.10": "utopic",
21 }
22
23
24@@ -87,6 +94,24 @@
25 "qttools5-dev:TARGET",
26 "qttools5-dev-tools:TARGET",
27 ],
28+ "ubuntu-sdk-14.10": [
29+ "cmake",
30+ "libqt5svg5-dev:TARGET",
31+ "libqt5webkit5-dev:TARGET",
32+ "libqt5xmlpatterns5-dev:TARGET",
33+ "libunity-scopes-dev:TARGET",
34+ "qt3d5-dev:TARGET",
35+ "qt5-default:TARGET",
36+ "qtbase5-dev:TARGET",
37+ "qtdeclarative5-dev:TARGET",
38+ "qtdeclarative5-dev-tools",
39+ "qtlocation5-dev:TARGET",
40+ "qtmultimedia5-dev:TARGET",
41+ "qtscript5-dev:TARGET",
42+ "qtsensors5-dev:TARGET",
43+ "qttools5-dev:TARGET",
44+ "qttools5-dev-tools:TARGET",
45+ ],
46 }
47
48
49
50=== modified file 'click/tests/test_framework.py'
51--- click/tests/test_framework.py 2014-03-10 14:49:27 +0000
52+++ click/tests/test_framework.py 2014-05-22 08:39:06 +0000
53@@ -72,9 +72,10 @@
54 enter()
55 self._setup_frameworks(
56 preloads,
57- frameworks={"ubuntu-sdk-13.10": {}, "ubuntu-sdk-14.04": {}})
58+ frameworks={"ubuntu-sdk-13.10": {}, "ubuntu-sdk-14.04": {},
59+ "ubuntu-sdk-14.10": {}})
60 self.assertEqual(
61- ["ubuntu-sdk-13.10", "ubuntu-sdk-14.04"],
62+ ["ubuntu-sdk-13.10", "ubuntu-sdk-14.04", "ubuntu-sdk-14.10"],
63 sorted(
64 f.props.name for f in Click.Framework.get_frameworks ()))
65

Subscribers

People subscribed via source and target branches

to all changes: