Merge lp:~lool/click/14.10-framework into lp:click
Status: | Rejected |
---|---|
Rejected by: | Colin Watson |
Proposed branch: | lp:~lool/click/14.10-framework |
Merge into: | lp:click |
Diff against target: |
64 lines (+28/-2) 2 files modified
click/chroot.py (+25/-0) click/tests/test_framework.py (+3/-2) |
To merge this branch: | bzr merge lp:~lool/click/14.10-framework |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson | Needs Resubmitting | ||
Review via email: mp+220581@code.launchpad.net |
Description of the change
Add 14.10 framework in places where all frameworks are listed.
I didn't change all references of 14.04 such as documentation as 14.10 is still in development. We probably want to do this near the end of the cycle.
I've tested this with click chroot create -a amd64 (created saucy chroot) and click chroot create -a amd64 -f ubuntu-sdk-14.10, and both worked. Package builds and that runs the testsuite. NB: I did hit testsuite failures with -j4 but that's not a regression from this branch and they go away when I drop the -j4.
Cheers,
Unmerged revisions
- 427. By PS Jenkins bot
-
Releasing 0.4.23.1
- 426. By Michael Vogt
-
Click 0.4.23: handle framework removal, x86 chroot support, and various other small fixes. Fixes: 1271944, 1294659, 1296820, 1319153, 1320786
This basically looks fine to me, but could you please resubmit this against lp:click/devel, which we're using as the target for individual MPs now?