lp:~loic.molinari/ubuntu-ui-toolkit/uitk-linux-clang

Branch merges

Propose for merging

1 branch dependent on this one.

Merged into lp:ubuntu-ui-toolkit/staging at revision 2123

ubuntu-sdk-build-bot: Approve (continuous-integration) on 2016-09-22

Zsombor Egri: Approve on 2016-09-22

Benjamin Zeller: Pending requested 2016-09-21

Diff: 154 lines (+47/-19)

6 files modified

.qmake.conf (+9/-0)
features/ubuntu_common.prf (+25/-13)
features/ubuntu_qml_plugin.prf (+4/-0)
features/ubuntu_qt_module.prf (+4/-0)
src/UbuntuMetrics/logger.h (+2/-2)
src/UbuntuToolkit/unitythemeiconprovider.cpp (+3/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2124. By Loïc Molinari on 2016-09-21

Forgot to add -Werror check in ubuntu_qml_plugin.

2123. By Loïc Molinari on 2016-09-21

Cleaned up comment.

2122. By Loïc Molinari on 2016-09-21

Fixed clang version detection.

2121. By Loïc Molinari on 2016-09-20

Made the toolkit build with linux-clang spec.

2120. By Loïc Molinari on 2016-09-20

Moved common C++ configs to ubuntu_common.prf.

The common config file doesn't add -Werror directly to QMAKE_CXXFLAGS anymore, it sets the warnings_are_errors variable so that it is correctly handled by different compilers (not just GCC). That allows to remove the -Werror=deprecated-declarations flag since warnings_are_errors defines it for us.

Removed the DEFINES += QT_USE_QSTRINGBUILDER lines since it's already handled by qt_module.prf.

Set the -Wsuggest-override warning to QMAKE_CXXFLAGS_WARN_ON instead of QMAKE_CXXFLAGS directly.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2119. By Loïc Molinari on 2016-09-20

Cleaned up qmake Ubuntu packaging variables.

The qtbase packaging for Ubuntu exports the CFLAGS, CXXFLAGS and LFLAGS variables in the environment before running configure so that the qtbase shared libraries can be compiled with the required distribution defined compiler flags. That is fine (though I guess that could be handled better at the qtbase packaging level with maybe a dedicated prf) but it results in qt_build_config.prf defining the QMAKE_CFLAGS, QMAKE_CXXFLAGS and QMAKE_LFLAGS variables with these distribution specific flags. Since we load this prf, these variables end up being defined when building the toolkit for development purpose. This is problematic because -O2 and -g are always defined (whatever the debug or release config chosen by the developer), also these are GCC specific flags which makes our build break with other compilers. This is also ugly because preprocessor defines are directly set in the QMAKE_C*FLAGS. In order to workaround these issues, we unset these variables and set the different flags apart from -g and -O2 in the right qmake variables. This allows to keep compiling with the Debian flags but in a more flexible way. For the Debian packaging, we keep the former behaviour by simply passing the debian_build config.

Approved by ubuntu-sdk-build-bot, Benjamin Zeller, Zsombor Egri.

2118. By Cris Dywan on 2016-09-20

__styleInstance may be null, when doesn't handle that. Fixes: https://bugs.launchpad.net/bugs/1586013.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2117. By Loïc Molinari on 2016-09-20

Made use of dedicated QT_BUILD_*_LIB define for our libs.

Creating a dedicated preprocessor define for each lib is not necessary as it's already handled by the Qt qt_build_config feature.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2116. By Cris Dywan on 2016-09-20

Use QStringLiteral with QString.replace

. Fixes: https://bugs.launchpad.net/bugs/1625507.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2115. By Cris Dywan on 2016-09-20

Use displayText to determine if the clear button should show. Fixes: https://bugs.launchpad.net/bugs/1461571.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.