Merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-include-cleanup into lp:ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1726
Merged at revision: 1750
Proposed branch: lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-include-cleanup
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 35 lines (+3/-8)
2 files modified
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+3/-7)
src/Ubuntu/Components/plugin/ucubuntushape.h (+0/-1)
To merge this branch: bzr merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntushape-include-cleanup
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+278439@code.launchpad.net

Commit message

[UbuntuShape] Cleaned up includes.

Description of the change

[UbuntuShape] Cleaned up includes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Nothin' fancy to review :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/plugin/ucubuntushape.cpp'
2--- src/Ubuntu/Components/plugin/ucubuntushape.cpp 2015-10-21 12:54:54 +0000
3+++ src/Ubuntu/Components/plugin/ucubuntushape.cpp 2015-11-24 11:55:14 +0000
4@@ -29,17 +29,13 @@
5 #include "ucubuntushapetexture.h"
6 #include "ucunits.h"
7 #include "quickutils.h"
8-#include <QtCore/QPointer>
9 #include <QtGui/QGuiApplication>
10-#include <QtGui/QScreen>
11-#include <QtQuick/QQuickWindow>
12-#include <QtQuick/QSGTextureProvider>
13+#include <QtQml/QQmlInfo>
14+#include <QtQuick/private/qsgadaptationlayer_p.h>
15+// This private header uses the emit keyword while we build with QT_NO_KEYWORDS set. See #1507910.
16 #define emit Q_EMIT
17 #include <QtQuick/private/qquickimage_p.h>
18 #undef emit
19-#include <QtQuick/private/qsgadaptationlayer_p.h>
20-#include <QtQml/qqmlinfo.h>
21-#include <math.h>
22
23 // Anti-aliasing distance of the contour in pixels.
24 const float distanceAApx = 1.75f;
25
26=== modified file 'src/Ubuntu/Components/plugin/ucubuntushape.h'
27--- src/Ubuntu/Components/plugin/ucubuntushape.h 2015-09-10 11:04:16 +0000
28+++ src/Ubuntu/Components/plugin/ucubuntushape.h 2015-11-24 11:55:14 +0000
29@@ -21,7 +21,6 @@
30
31 #include <QtQuick/QQuickItem>
32 #include <QtQuick/QSGNode>
33-#include <QtQuick/qsgtexture.h>
34 #include <QtQuick/qsgmaterial.h>
35 #include <QtGui/QOpenGLFunctions>
36

Subscribers

People subscribed via source and target branches