Merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-set-shapes-debug-description into lp:ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Merged
Approved by: Tim Peeters
Approved revision: 1459
Merged at revision: 1495
Proposed branch: lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-set-shapes-debug-description
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 27 lines (+6/-0)
2 files modified
modules/Ubuntu/Components/plugin/ucubuntushape.cpp (+3/-0)
modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.cpp (+3/-0)
To merge this branch: bzr merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-set-shapes-debug-description
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+254425@code.launchpad.net

Description of the change

Set QSGNode debug description on the shape-based nodes to ease renderer debugging.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Nobrainer :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-autolanding/179/console Failed due to a failure on the build slave. It's been fixed and this MP can be re-approved.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/plugin/ucubuntushape.cpp'
2--- modules/Ubuntu/Components/plugin/ucubuntushape.cpp 2015-03-10 13:25:19 +0000
3+++ modules/Ubuntu/Components/plugin/ucubuntushape.cpp 2015-03-27 16:38:31 +0000
4@@ -162,6 +162,9 @@
5 m_geometry.setVertexDataPattern(vertexDataPattern);
6 setMaterial(&m_material);
7 setGeometry(&m_geometry);
8+#ifdef QSG_RUNTIME_DESCRIPTION
9+ qsgnode_set_description(this, QLatin1String("ubuntushape"));
10+#endif
11 }
12
13 // static
14
15=== modified file 'modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.cpp'
16--- modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.cpp 2015-03-10 12:16:04 +0000
17+++ modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.cpp 2015-03-27 16:38:31 +0000
18@@ -67,6 +67,9 @@
19 m_geometry.setVertexDataPattern(ShapeNode::vertexDataPattern);
20 setMaterial(&m_material);
21 setGeometry(&m_geometry);
22+#ifdef QSG_RUNTIME_DESCRIPTION
23+ qsgnode_set_description(this, QLatin1String("ubuntushapeoverlay"));
24+#endif
25 }
26
27 // static

Subscribers

People subscribed via source and target branches