Merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-make-use-of-frame into lp:ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1816
Merged at revision: 1815
Proposed branch: lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-make-use-of-frame
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 47 lines (+11/-20)
1 file modified
src/Ubuntu/Components/Themes/Ambiance/1.3/FocusShape.qml (+11/-20)
To merge this branch: bzr merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-make-use-of-frame
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+283492@code.launchpad.net

Commit message

Made use of new private Frame item for the focusing.

Description of the change

Made use of new private Frame item for the focusing.

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Small fix and we're good.

review: Needs Fixing
1816. By Loïc Molinari

Fixed color.

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Thank you!!!!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/FocusShape.qml'
2--- src/Ubuntu/Components/Themes/Ambiance/1.3/FocusShape.qml 2015-12-17 10:03:55 +0000
3+++ src/Ubuntu/Components/Themes/Ambiance/1.3/FocusShape.qml 2016-01-21 15:44:52 +0000
4@@ -18,27 +18,19 @@
5
6 import QtQuick 2.4
7 import Ubuntu.Components 1.3
8-
9-UbuntuShape {
10- property color focusColor: UbuntuColors.orange // FIXME: Use color from palette
11-
12+import Ubuntu.Components.Private 1.3
13+
14+Frame {
15 anchors.fill: parent
16- anchors.margins: -units.gu(0.4)
17- backgroundColor: Qt.rgba(focusColor.r, focusColor.g, focusColor.b, 1.0)
18+ anchors.margins: -units.gu(0.46)
19+ color: UbuntuColors.orange // FIXME: Use color from palette
20+ thickness: units.gu(0.21)
21+ radius: units.gu(1.7)
22 visible: styledItem.keyNavigationFocus
23- z: styledItem.z - 1
24-
25- UbuntuShape {
26- anchors.fill: parent
27- anchors.margins: styledItem.keyNavigationFocus ? units.gu(0.2) : 0
28- backgroundColor: theme.palette.normal.background
29- aspect: UbuntuShape.Flat
30- visible: parent.visible
31-
32- Behavior on anchors.margins {
33- UbuntuNumberAnimation {
34- duration: UbuntuAnimation.FastDuration
35- }
36+
37+ Behavior on anchors.margins {
38+ UbuntuNumberAnimation {
39+ duration: UbuntuAnimation.FastDuration
40 }
41 }
42
43@@ -49,4 +41,3 @@
44 when: styledItem
45 }
46 }
47-

Subscribers

People subscribed via source and target branches