Merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-add-version-to-lttng-plugin-path into lp:ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Needs review
Proposed branch: lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-add-version-to-lttng-plugin-path
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 31 lines (+3/-3)
3 files modified
debian/libubuntumetrics5.install (+1/-1)
src/Ubuntu/UbuntuMetrics/UbuntuMetrics.pro (+1/-1)
src/Ubuntu/UbuntuMetrics/lttng/lttng.pro (+1/-1)
To merge this branch: bzr merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-metrics-add-version-to-lttng-plugin-path
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Loïc Molinari (community) Needs Information
Review via email: mp+304119@code.launchpad.net

Commit message

Added version to LTTng plugin path.

That's to avoid broken upgrades on soname bump as required by Ubuntu packaging guidelines (the $$[QT_INSTALL_PLUGINS] doesn't seem to be enough).

Description of the change

Added version to LTTng plugin path.

That's to avoid broken upgrades on soname bump as required by Ubuntu packaging guidelines (the $$[QT_INSTALL_PLUGINS] doesn't seem to be enough).

To post a comment you must log in.
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Now that's not critical anymore, I think it would be better to use the UITK version instead. Is there a UITK_VERSION variable to be expanded in the .pro?

review: Needs Information
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Unmerged revisions

2084. By Loïc Molinari

Added version to LTTng plugin path.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/libubuntumetrics5.install'
2--- debian/libubuntumetrics5.install 2016-07-26 17:07:42 +0000
3+++ debian/libubuntumetrics5.install 2016-08-26 17:56:11 +0000
4@@ -1,2 +1,2 @@
5 usr/lib/*/libUbuntuMetrics.so.*
6-usr/lib/*/qt5/plugins/ubuntu/metrics/libumlttng.so
7+usr/lib/*/qt5/plugins/ubuntu/metrics/*/libumlttng.so
8
9=== modified file 'src/Ubuntu/UbuntuMetrics/UbuntuMetrics.pro'
10--- src/Ubuntu/UbuntuMetrics/UbuntuMetrics.pro 2016-08-04 22:54:21 +0000
11+++ src/Ubuntu/UbuntuMetrics/UbuntuMetrics.pro 2016-08-26 17:56:11 +0000
12@@ -9,7 +9,7 @@
13 DEFINES += MESA_EGL_NO_X11_HEADERS
14 }
15
16-DEFINES += LTTNG_PLUGIN_INSTALL_PATH=\\\"$$[QT_INSTALL_PLUGINS]/ubuntu/metrics/libumlttng.so\\\"
17+DEFINES += LTTNG_PLUGIN_INSTALL_PATH=\\\"$$[QT_INSTALL_PLUGINS]/ubuntu/metrics/$$[QT_VERSION]/libumlttng.so\\\"
18 DEFINES += LTTNG_PLUGIN_BUILD_PATH=\\\"$$OUT_PWD/lttng/libumlttng.so\\\"
19
20 load(qt_build_config)
21
22=== modified file 'src/Ubuntu/UbuntuMetrics/lttng/lttng.pro'
23--- src/Ubuntu/UbuntuMetrics/lttng/lttng.pro 2016-07-26 11:03:34 +0000
24+++ src/Ubuntu/UbuntuMetrics/lttng/lttng.pro 2016-08-26 17:56:11 +0000
25@@ -4,5 +4,5 @@
26 CONFIG += plugin
27 LIBS += -llttng-ust
28 SOURCES = tracepoints.c lttng.c
29-target.path = $$[QT_INSTALL_PLUGINS]/ubuntu/metrics
30+target.path = $$[QT_INSTALL_PLUGINS]/ubuntu/metrics/$$[QT_VERSION]
31 INSTALLS += target

Subscribers

People subscribed via source and target branches