Code review comment for ~locnnil/ubuntu/+source/linuxptp:oracular-linuxptp-add-apparmor

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Comments inline, and here.

Commit db64e3ff9c7a60b8164b2dab035add4587d6f177 is also changing d/usr.sbin.ptp4l, which is not mentioned in the commit message. This of course does not change the final outcome, but since you have split commits, maybe you would prefer to move that ptp4l change to commit f1788a09e84df88d2c142a34ab6b5ad110ddb050 which is the one adding that apparmor profile.

review: Needs Fixing

« Back to merge proposal