Merge lp:~lmi/openerp-connector/7.0-pass-vals-to-events into lp:~openerp-connector-core-editors/openerp-connector/7.0

[Laurent Mignon (Acsone)]

* Pass a new parameter to listeners of 'on_recrod_write' ( vals: field values of the new record, e.g {'field_name': field_value, ...})
* Replace the list of updated fields passed to listeners of 'on_record_write' by a dictionary of updated field values e.g {'field_name': field_value, ...}

[Laurent Mignon (Acsone) (lmi)]

sorry.. resubmitted

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks!

2 little things:
l.8 The new arg is on 'on_record_create', not 'on_recrod_write'
l.81 Can you align 'city' with 'name' ?

I'll make the changes for the Magento Connector, if someone want to do it for the Prestashop one, let us know here.

The changes to do are:
 * change the name of the argument and to use vals.keys() in all the consumers of on_record_write
 * add the argument vals in all the consumers of on_record_create

This change needs to be done in others connectors I'm not aware of, but it has been discussed on the mailing list and here so I hope the developers follow theses channels.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Forgot to set the review tag

review: Needs Fixing

[lp:~lmi/openerp-connector/7.0-pass-vals-to-events]

588. By Laurent Mignon (Acsone) on 2013-10-04

The new arg is on 'on_record_create', not 'on_recrod_write'

589. By Laurent Mignon (Acsone) on 2013-10-04

pep8

[Laurent Mignon (Acsone) (lmi)]

Thanks for the review!

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Here is the MP for the Magento Connector: https://code.launchpad.net/~openerp-connector-community/openerp-connector/7.0-magentoerpconnect-pass-vals-to-events/+merge/189295

I approve your MP and thank you again for taking the time to propose the change and develop it.

We will need to merge all the MPs (connector + Magento + Prestashop) at the same time.

review: Approve (code review, test)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

And here is the MP for prestashoperpconnect: https://code.launchpad.net/~camptocamp/prestashoperpconnect/7.0-pass-vals-to-events/+merge/190227

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Good work and thanks Guewen for the merge proposal on Magento and Prestashop
LGTM

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> And here is the MP for prestashoperpconnect:
> https://code.launchpad.net/~camptocamp/prestashoperpconnect/7.0-pass-vals-to-
> events/+merge/190227

New url: https://code.launchpad.net/~openerp-community/prestashoperpconnect/7.0-pass-vals-to-events/+merge/190227

[Laurent Mignon (Acsone) (lmi)]

review: Abstain

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Just to say I did not forget this MP. I want to merge all the proposals breaking the API backward compatibility at the same time.

[Laurent Mignon (Acsone) (lmi)]

Ok,
Thank you for the information

On Mon, Dec 9, 2013 at 1:34 PM, Guewen Baconnier @ Camptocamp <
<email address hidden>> wrote:

> Just to say I did not forget this MP. I want to merge all the proposals
> breaking the API backward compatibility at the same time.
> --
>
> https://code.launchpad.net/~lmi/openerp-connector/7.0-pass-vals-to-events/+merge/189234
> You are the owner of lp:~lmi/openerp-connector/7.0-pass-vals-to-events.
>

--
*Laurent Mignon*
*Senior Software Engineer*

*Tel : [phone]*
*Fax : [phone]*
*Gsm : [phone]*
*Email: <email address hidden> <email address hidden>*

*Acsone SA, Succursale de Luxembourg*
*22, Zone industrielle*
*L-8287 Kehlen, Luxembourg*
*www.acsone.eu <http://www.acsone.eu>*

=== modified file 'connector/CHANGES.rst'
--- connector/CHANGES.rst	2013-09-12 15:00:20 +0000
+++ connector/CHANGES.rst	2013-10-04 09:36:28 +0000
@@ -4,6 +4,9 @@
 2.0.1.dev0
 ~~~~~~~~~~
 
+* Pass a new parameter to listeners of 'on_recrod_create' ( vals:  field values of the new record, e.g {'field_name': field_value, ...})
+* Replace the list of updated fields passed to listeners of 'on_record_write' by a dictionary of updated field values e.g {'field_name': field_value, ...}
+
 2.0.1 (2013-09-12)
 ~~~~~~~~~~~~~~~~~~
 

=== modified file 'connector/event.py'
--- connector/event.py	2013-06-28 13:45:31 +0000
+++ connector/event.py	2013-10-04 09:36:28 +0000
@@ -188,7 +188,7 @@
  * session: :py:class:`~connector.session.ConnectorSession` object
  * model_name: name of the model
  * record_id: id of the record
- * fields: list with names of the fields which have been written
+ * vals:  field values of the new record, e.g {'field_name': field_value, ...}
 
 """
 
@@ -201,6 +201,7 @@
  * session: :py:class:`~connector.session.ConnectorSession` object
  * model_name: name of the model
  * record_id: id of the created record
+ * vals:  field values updated, e.g {'field_name': field_value, ...}
 
 """
 

=== modified file 'connector/producer.py'
--- connector/producer.py	2013-04-23 13:27:22 +0000
+++ connector/producer.py	2013-10-04 09:36:28 +0000
@@ -42,7 +42,7 @@
     record_id = create_original(self, cr, uid, vals, context=context)
     if self.pool.get('connector.installed') is not None:
         session = ConnectorSession(cr, uid, context=context)
-        on_record_create.fire(session, self._name, record_id)
+        on_record_create.fire(session, self._name, record_id, vals)
     return record_id
 orm.Model.create = create
 
@@ -57,7 +57,7 @@
         if on_record_write.has_consumer_for(session, self._name):
             for record_id in ids:
                 on_record_write.fire(session, self._name,
-                                     record_id, vals.keys())
+                                     record_id, vals)
     return result
 orm.Model.write = write
 

=== modified file 'connector/tests/test_producer.py'
--- connector/tests/test_producer.py	2013-04-23 11:58:21 +0000
+++ connector/tests/test_producer.py	2013-10-04 09:36:28 +0000
@@ -32,7 +32,7 @@
         Create a record and check if the event is called
         """
         @on_record_create
-        def event(session, model_name, record_id):
+        def event(session, model_name, record_id, vals):
             self.recipient.record_id = record_id
 
         record_id = self.model.create(self.cr,
@@ -46,17 +46,18 @@
         Write on a record and check if the event is called
         """
         @on_record_write
-        def event(session, model_name, record_id, fields=None):
+        def event(session, model_name, record_id, vals=None):
             self.recipient.record_id = record_id
-            self.recipient.fields = fields
+            self.recipient.vals = vals
 
+        vals =  {'name': 'Lrrr',
+                 'city': 'Omicron Persei 8'}
         self.model.write(self.cr,
                          self.uid,
                          self.partner_id,
-                         {'name': 'Lrrr',
-                          'city': 'Omicron Persei 8'})
+                         vals)
         self.assertEqual(self.recipient.record_id, self.partner_id)
-        self.assertItemsEqual(self.recipient.fields, ['name', 'city'])
+        self.assertDictEqual(self.recipient.vals, vals)
         on_record_write.unsubscribe(event)
 
     def test_on_record_unlink(self):