charm-nrpe:candidate/21.10

Last commit made on 2021-10-10
Get this branch:
git clone -b candidate/21.10 https://git.launchpad.net/charm-nrpe
Members of Llama (LMA) Charmers can upload to this branch. Log in for directions.

Branch merges

Branch information

Name:
candidate/21.10
Repository:
lp:charm-nrpe

Recent commits

e3888d2... by Xav Paice

update charmhelpers

dcdef1b... by Joe Guo

Add missing update-status hook

Currently in nrpe charm, the update-status hook is missing. We keep seeing this message in juju log:

unit-nrpe-0: 20:47:06 INFO juju.worker.uniter.operation skipped "update-status" hook (missing)

This patch added a separate python script for this hook, to check nagios-nrpe-server status and use status-set hook tool to update status.
The status message is kept identical to before.

Reviewed-on: https://code.launchpad.net/~guoqiao/charm-nrpe/+git/nrpe-charm/+merge/409732
Reviewed-by: Xav Paice <email address hidden>
Reviewed-by: Linda Guo <email address hidden>

5342ff7... by Joe Guo

add missing update-status hook with python script

status message is identical to what was defined in services.py.

d76fc12... by Joe Guo

hooks/services.py: extract get_revision() to reuse

Signed-off-by: Joe Guo <email address hidden>

951d415... by Xav Paice

Add target-address to relation data

    The Nagios charm makes use of a relation-data item named target-address,
    which is used for connections from Nagios to the remote unit (NRPE).
    If target-address is not set, Nagios then uses ingress-address, and if
    that's not set, private-address. Both ingress-address and
    private-address are automatically set by Juju, but updated by the nrpe
    charm.

    This change adds target-address to the relation data which is controlled
    by the NRPE charm from the start, as under some circumstances the
    ingress-address is overwritten by Juju.

Reviewed-on: https://code.launchpad.net/~xavpaice/charm-nrpe/+git/nrpe-charm/+merge/409109
Reviewed-by: James Troup <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

8fedd69... by Xav Paice

Add target-address to relation data

The Nagios charm makes use of a relation-data item named target-address,
which is used for connections from Nagios to the remote unit (NRPE).
If target-address is not set, Nagios then uses ingress-address, and if
that's not set, private-address. Both ingress-address and
private-address are automatically set by Juju, but updated by the nrpe
charm.

This change adds target-address to the relation data which is controlled
by the NRPE charm from the start, as under some circumstances the
ingress-address is overwritten by Juju.

74ca861... by Xav Paice

Bind NRPE to local address

    In cases where we specify to use public address and/or Juju returns a
    public address regardless of the setting, we cannot use that address for
    binding the NRPE service.

    This change ensures get_local_ingress_address returns the local address
    for binding the nrpe service, and if configured to do so returns the
    public address for relation data and NRPE host exports.

Reviewed-on: https://code.launchpad.net/~xavpaice/charm-nrpe/+git/nrpe-charm/+merge/408524
Reviewed-by: James Troup <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

4344ba9... by Xav Paice

Remove pre-Juju 2.3 support for ingress

Determines the ingress address using info only avaialbe after Juju 2.3
was released.

a46e8c6... by Xav Paice

set constraints for tests in Focal bundle

The Focal bundle needs more root-disk than default in some environments
to run containers. This change increases the minimum to allow for this.

Additionally adds a smoke test bundle definition.

4f7b0a0... by Xav Paice

Bind NRPE to local address

In cases where we specify to use public address and/or Juju returns a
public address regardless of the setting, we cannot use that address for
binding the NRPE service.

This change ensures get_local_ingress_address returns the local address
for binding the nrpe service, and if configured to do so returns the
public address for relation data and NRPE host exports.