Merge charm-grafana:bug/1925278 into charm-grafana:master

Proposed by Xav Paice
Status: Merged
Approved by: James Troup
Approved revision: 3559c6cb058bf88728ca35dda57c6ff496c9d490
Merged at revision: f919967fd52bb650361b6ce1bd23ab699fa6e3bb
Proposed branch: charm-grafana:bug/1925278
Merge into: charm-grafana:master
Diff against target: 28 lines (+11/-0)
2 files modified
src/tests/functional/requirements.txt (+1/-0)
src/tox.ini (+10/-0)
Reviewer Review Type Date Requested Status
Paul Goins Approve
🤖 prod-jenkaas-bootstack continuous-integration Needs Fixing
BootStack Reviewers Pending
Review via email: mp+401583@code.launchpad.net

Commit message

Add python-openstackclient to functests

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :

cRT130660 raised for the proxy change to allow the package download that's failing.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Paul Goins (vultaire) wrote :

+1 from me, but please fix the CI failures if you can.

It looks like there was a test for presence of python3-pip which failed.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision f919967fd52bb650361b6ce1bd23ab699fa6e3bb

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/tests/functional/requirements.txt b/src/tests/functional/requirements.txt
2index b7c9112..bbe8435 100644
3--- a/src/tests/functional/requirements.txt
4+++ b/src/tests/functional/requirements.txt
5@@ -1 +1,2 @@
6 git+https://github.com/openstack-charmers/zaza.git#egg=zaza
7+python-openstackclient
8diff --git a/src/tox.ini b/src/tox.ini
9index 24fb13b..5845e03 100644
10--- a/src/tox.ini
11+++ b/src/tox.ini
12@@ -21,6 +21,16 @@ passenv =
13 NO_PROXY
14 SNAP_HTTP_PROXY
15 SNAP_HTTPS_PROXY
16+ OS_REGION_NAME
17+ OS_AUTH_VERSION
18+ OS_AUTH_URL
19+ OS_PROJECT_DOMAIN_NAME
20+ OS_USERNAME
21+ OS_PASSWORD
22+ OS_PROJECT_ID
23+ OS_USER_DOMAIN_NAME
24+ OS_PROJECT_NAME
25+ OS_IDENTITY_API_VERSION
26
27 [testenv:lint]
28 commands =

Subscribers

No one subscribed via source and target branches