Merge lp:~liuyq0307/linaro-android-frontend/add-measurement-for-testresult-table into lp:linaro-android-frontend

Proposed by Yongqin Liu
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 235
Merged at revision: 234
Proposed branch: lp:~liuyq0307/linaro-android-frontend/add-measurement-for-testresult-table
Merge into: lp:linaro-android-frontend
Diff against target: 31 lines (+20/-1)
1 file modified
static/buildDetails.js (+20/-1)
To merge this branch: bzr merge lp:~liuyq0307/linaro-android-frontend/add-measurement-for-testresult-table
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+80018@code.launchpad.net

Description of the change

Add modification for display measurement of each test

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/buildDetails.js'
2--- static/buildDetails.js 2011-08-26 01:35:27 +0000
3+++ static/buildDetails.js 2011-10-21 04:08:23 +0000
4@@ -34,7 +34,26 @@
5 }
6 },
7 {label:"Pass", formatter: function (o) { return o.data.results.pass || 0; } },
8- {label:"Fail", formatter: function (o) { return o.data.results.fail || 0; } }
9+ {label:"Fail", formatter: function (o) { return o.data.results.fail || 0; } },
10+ {label:"Measurement", formatter: function (o) {
11+ var measurements = o.data.results.measurements;
12+ if (!measurements || (measurements.length == 0)){
13+ return " ";
14+ }
15+ var contents = new Array();
16+ var index = 0;
17+ for (var index=0; index < measurements.length; index++){
18+ var item = measurements[index];
19+ var oneLine = "<tr>";
20+ oneLine = oneLine + "<td style='width:225px; border:1px solid #999999;'>" + item.item +"</td>";
21+ oneLine = oneLine + "<td style='width:185px; border:1px solid #999999; text-align:right;'>" + item.measurement +"</td>";
22+ oneLine = oneLine + "<td style='width:60px; border:1px solid #999999; text-align:right;'>" + item.units +"</td>";
23+ oneLine = oneLine + "</tr>";
24+ contents[index] = oneLine;
25+ }
26+ return "<table style='font-family:Verdana,Lucida,Arial,sans-serif;'>"+contents.join(" ")+"</table>";
27+
28+ }}
29 ];
30 var recordset = new Y.Recordset({records: response.test_runs});
31 var newTable = Y.Node.create('<table/>');

Subscribers

People subscribed via source and target branches