Merge lp:~liuyq0307/linaro-android-build-tools/install-break into lp:linaro-android-build-tools

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 609
Proposed branch: lp:~liuyq0307/linaro-android-build-tools/install-break
Merge into: lp:linaro-android-build-tools
Diff against target: 20 lines (+4/-2)
1 file modified
build-scripts/post-build-lava.py (+4/-2)
To merge this branch: bzr merge lp:~liuyq0307/linaro-android-build-tools/install-break
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+160026@code.launchpad.net

Description of the change

changed to use one lava-android-test-install actions for each test, instead of using one lava-android-test-install action for all tests, by doing this way the next test installation will not be broken when the one installation before it failed.

tested with this job: http://staging.validation.linaro.org/scheduler/job/44607

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Hi, Infrastructure team,

Anyone can help to review this modification?

Thanks,
Yongqin Liu

Revision history for this message
Milo Casagrande (milo) wrote :

Hello there,

my apologies for taking so long to review this.
It looks good for me, also based on the job already tested. Are there any examples of it being in use?

Overall I would say +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/post-build-lava.py'
2--- build-scripts/post-build-lava.py 2013-03-27 07:41:55 +0000
3+++ build-scripts/post-build-lava.py 2013-04-22 07:52:43 +0000
4@@ -142,12 +142,14 @@
5 continue
6 test_actions.append(test)
7
8- if len(test_actions) > 0:
9+ ## make the next test installation be able to execute
10+ ## when one test installation failed
11+ for test_action in list(set(test_actions)):
12 inst_action = {
13 "command": "lava_android_test_install",
14 "parameters": {
15 # ensure only unique test names
16- "tests": list(set(test_actions))
17+ "tests": [test_action]
18 }
19 }
20 actions.append(inst_action)

Subscribers

People subscribed via source and target branches