Code review comment for lp:~liuyq0307/lava-dispatcher/fix-1195536

Revision history for this message
Tyler Baker (tyler-baker) wrote :

> Hi, Tyler
> I updated the definition of simulator_initrd_files and simulator_kernel_files
> according to your comments.
> Please check that.
> > We should also update the device-types for the following:
> >
> > rtsm_foundation-armv8
> >
> > rtsm_ve-armv8
> For the above comments, sorry, I am not very clear about what to do.
> Why should we update these two device types.
> They don't need to specify the simulator_initrd_files and
> simulator_kernel_files now.

At this point they do not. However in the future they will need to ;) We can do this work now or later, I just thought it might be nice to have them updated now.

« Back to merge proposal