Merge lp:~liuyq0307/lava-deployment-tool/modify-login-url into lp:~linaro-validation/lava-deployment-tool/trunk

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 181
Proposed branch: lp:~liuyq0307/lava-deployment-tool/modify-login-url
Merge into: lp:~linaro-validation/lava-deployment-tool/trunk
Diff against target: 25 lines (+3/-1)
1 file modified
lava-deployment-tool (+3/-1)
To merge this branch: bzr merge lp:~liuyq0307/lava-deployment-tool/modify-login-url
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+108542@code.launchpad.net

Description of the change

modify the LOGIN_URL in settings.conf to make it redirect to the login page correctly
when click [API->Authentication Tokens] menu.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good

+-e bzr+lp:lava-android-test#egg=lava-android-test

Is this something we need as well?

review: Approve
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> Looks good
>
> +-e bzr+lp:lava-android-test#egg=lava-android-test
>
> Is this something we need as well?

Sorry, this is not intended. only the lava-deployment-tool file is needed.
If possible, please ignore the requirements-trunk.txt file when merge.
Otherwise, I will update & merge this branch tomorrow.

181. By Yongqin Liu

revert requirements-trunk.txt to not include the lava-android-text

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava-deployment-tool'
2--- lava-deployment-tool 2012-06-04 09:56:48 +0000
3+++ lava-deployment-tool 2012-06-05 01:28:20 +0000
4@@ -1852,6 +1852,7 @@
5 sudo rm /etc/apache2/conf.d/${LAVA_INSTANCE}.conf
6 sed -i "s/ \"MEDIA_URL\": \"\/${LAVA_INSTANCE}-media\/\",/ \"MEDIA_URL\": \"\/media\/\",/" ${settings_file}
7 sed -i "s/ \"STATIC_URL\": \"\/${LAVA_INSTANCE}-static\/\",/ \"STATIC_URL\": \"\/static\/\",/" ${settings_file}
8+ sed -i "s/ \"LOGIN_URL\": \"\/${LAVA_INSTANCE}\/accounts\/login\/\",/ \"LOGIN_URL\": \"\/accounts\/login\/\",/" ${settings_file}
9 sed -i "s/ \"LOGIN_REDIRECT_URL\": \"\/${LAVA_INSTANCE}\",/ \"LOGIN_REDIRECT_URL\": \"\/\",/" ${settings_file}
10 touch ${reload_file}
11 sudo a2ensite $LAVA_INSTANCE.conf
12@@ -1872,11 +1873,12 @@
13 sudo ln -s ${single_conf} /etc/apache2/conf.d/${LAVA_INSTANCE}.conf
14 sed -i "s/ \"MEDIA_URL\": \"\/media\/\",/ \"MEDIA_URL\": \"\/${LAVA_INSTANCE}-media\/\"\,/" ${settings_file}
15 sed -i "s/ \"STATIC_URL\": \"\/static\/\",/ \"STATIC_URL\": \"\/${LAVA_INSTANCE}-static\/\",/" ${settings_file}
16+ sed -i "s/ \"LOGIN_URL\": \"\/accounts\/login\/\",/ \"LOGIN_URL\": \"\/${LAVA_INSTANCE}\/accounts\/login\/\",/" ${settings_file}
17 sed -i "s/ \"LOGIN_REDIRECT_URL\": \"\/\",/ \"LOGIN_REDIRECT_URL\": \"\/${LAVA_INSTANCE}\",/" ${settings_file}
18 touch ${reload_file}
19 return 0
20 else
21- echo 'target must be specified with "site" or "singleip"'
22+ echo 'target must be specified with "vhost" or "location"'
23 return 1
24 fi
25 }

Subscribers

People subscribed via source and target branches