Merge lp:~liuyq0307/lava-android-test/removing-external-tools into lp:lava-android-test

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 125
Proposed branch: lp:~liuyq0307/lava-android-test/removing-external-tools
Merge into: lp:lava-android-test
Diff against target: 91 lines (+10/-24)
5 files modified
MANIFEST.in (+0/-2)
external/__init__.py (+0/-1)
lava_android_test/swprofile.py (+2/-8)
lava_android_test/testdef.py (+1/-6)
tests/test_swprofile.py (+7/-7)
To merge this branch: bzr merge lp:~liuyq0307/lava-android-test/removing-external-tools
Reviewer Review Type Date Requested Status
Paul Larson (community) Approve
Review via email: mp+87123@code.launchpad.net

Description of the change

remove the external tools from lava-android-test source, and changed to use the command built into android by default.
so this branch depends on the change of android source :http://review.android.git.linaro.org/#change,1322

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MANIFEST.in'
2--- MANIFEST.in 2011-11-21 04:00:57 +0000
3+++ MANIFEST.in 2011-12-30 08:23:23 +0000
4@@ -1,8 +1,6 @@
5 include COPYING
6 include README
7 include .testr.conf
8-include external/lavatools/*
9-include external/screencap/*
10 include lava_android_test/test_definitions/monkey/*
11 include lava_android_test/test_definitions/android-0xbenchmark/*
12 include lava_android_test/test_definitions/busybox/*
13
14=== removed directory 'external'
15=== removed file 'external/__init__.py'
16--- external/__init__.py 2011-10-31 06:40:33 +0000
17+++ external/__init__.py 1970-01-01 00:00:00 +0000
18@@ -1,1 +0,0 @@
19-
20
21=== removed directory 'external/lavatools'
22=== removed file 'external/lavatools/lavatools.jar'
23Binary files external/lavatools/lavatools.jar 2011-10-19 06:05:16 +0000 and external/lavatools/lavatools.jar 1970-01-01 00:00:00 +0000 differ
24=== removed directory 'external/screencap'
25=== removed file 'external/screencap/screencap'
26Binary files external/screencap/screencap 2011-10-19 08:30:26 +0000 and external/screencap/screencap 1970-01-01 00:00:00 +0000 differ
27=== modified file 'lava_android_test/swprofile.py'
28--- lava_android_test/swprofile.py 2011-10-20 13:33:36 +0000
29+++ lava_android_test/swprofile.py 2011-12-30 08:23:23 +0000
30@@ -58,16 +58,10 @@
31 def get_package_info(adb=ADB()):
32
33 packages_info = []
34- config = get_config()
35- curdir = os.path.realpath(os.path.dirname(__file__))
36- lavatool_path = os.path.join(os.path.dirname(curdir), 'external', 'lavatools')
37- lavatool_jar = 'lavatools.jar'
38- target_path = os.path.join(config.tempdir_android, lavatool_jar)
39- adb.push(os.path.join(lavatool_path, lavatool_jar), target_path)
40- pkginfo = adb.get_shellcmdoutput('CLASSPATH=%s exec app_process /system/bin org.linaro.lavatools.LavaTools list-packages' % target_path)[1]
41+ pkginfo = adb.get_shellcmdoutput('/system/bin/pm list packages -v')[1]
42 if pkginfo is None:
43 return packages_info
44- pattern = re.compile('^\s*(?P<package_name>[^:]+?)\s*:\s*(?P<version>[^\s].+)\s*$', re.M)
45+ pattern = re.compile('^\s*package:\s*(?P<package_name>[^:]+?)\s*:\s*(?P<version>[^\s].+)\s*$', re.M)
46 for line in pkginfo:
47 match = pattern.search(line)
48 if match :
49
50=== modified file 'lava_android_test/testdef.py'
51--- lava_android_test/testdef.py 2011-11-14 12:05:55 +0000
52+++ lava_android_test/testdef.py 2011-12-30 08:23:23 +0000
53@@ -156,12 +156,7 @@
54 return result_id
55
56 def _screencap(self, resultsdir):
57- config = get_config()
58- curdir = os.path.realpath(os.path.dirname(__file__))
59- screencap_path = os.path.join(os.path.dirname(curdir), 'external', 'screencap', 'screencap')
60- target_path = os.path.join(config.tempdir_android, 'screencap')
61- self.adb.push(screencap_path, target_path)
62- self.adb.shell('chmod 777 %s' % target_path)
63+ target_path = '/system/bin/screenshot'
64 self.adb.shell('%s %s' % (target_path, os.path.join(resultsdir, 'screencap.png')))
65
66 def _copyorgoutputfile(self, resultsdir):
67
68=== modified file 'tests/test_swprofile.py'
69--- tests/test_swprofile.py 2011-12-08 11:14:20 +0000
70+++ tests/test_swprofile.py 2011-12-30 08:23:23 +0000
71@@ -18,13 +18,13 @@
72 import lava_android_test.swprofile
73 from tests.tests_util import fake_adb, clear_fake
74
75-package_list_info = '''android:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
76-com.android.musicvis:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
77-com.android.videoeditor:1.1 (#11)
78-com.android.vpndialogs:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
79-com.android.wallpaper:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
80-com.android.wallpaper.livepicker:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
81-com.svox.pico:1.0 (#1)'''
82+package_list_info = '''package:android:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
83+package:com.android.musicvis:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
84+package:com.android.videoeditor:1.1 (#11)
85+package:com.android.vpndialogs:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
86+package:com.android.wallpaper:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
87+package:com.android.wallpaper.livepicker:4.0.1.2.3.4.5.6.7.8.9-3 (#14)
88+package:com.svox.pico:1.0 (#1)'''
89
90 getprop_info = '''[dalvik.vm.heapsize]: [24m]
91 [dalvik.vm.stack-trace-file]: [/data/anr/traces.txt]

Subscribers

People subscribed via source and target branches