Merge lp:~liuyq0307/lava-android-test/fix-ppm-url into lp:lava-android-test

Proposed by Yongqin Liu
Status: Merged
Approved by: Fathi Boudra
Approved revision: 153
Merged at revision: 162
Proposed branch: lp:~liuyq0307/lava-android-test/fix-ppm-url
Merge into: lp:lava-android-test
Diff against target: 52 lines (+9/-9)
1 file modified
lava_android_test/test_definitions/tjbench.py (+9/-9)
To merge this branch: bzr merge lp:~liuyq0307/lava-android-test/fix-ppm-url
Reviewer Review Type Date Requested Status
Andy Doan Pending
Yongqin Liu Pending
Review via email: mp+108900@code.launchpad.net

This proposal supersedes a proposal from 2012-05-09.

Description of the change

updated the url of ppm file to the following url:
http://testdata.validation.linaro.org/tjbench/nightshot_iso_100.ppm

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote : Posted in a previous version of this proposal

tested

review: Approve
Revision history for this message
Fathi Boudra (fboudra) wrote : Posted in a previous version of this proposal

we don't have a policy on the paths to use. I replied on the mailing list

Revision history for this message
Yongqin Liu (liuyq0307) wrote : Posted in a previous version of this proposal

sorry, saw the mail after merged.
Have overwritten with version 151 now.

Will update and merge after decided

Revision history for this message
Andy Doan (doanac) wrote : Posted in a previous version of this proposal

let's hold off on the merge until the naming scheme for files is settled on the mailing list.

review: Needs Fixing
154. By Yongqin Liu

merge with trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_android_test/test_definitions/tjbench.py'
2--- lava_android_test/test_definitions/tjbench.py 2012-04-18 14:22:26 +0000
3+++ lava_android_test/test_definitions/tjbench.py 2012-06-06 09:26:18 +0000
4@@ -26,8 +26,8 @@
5 config = get_config()
6 curdir = os.path.realpath(os.path.dirname(__file__))
7 ppm_file_name = 'nightshot_iso_100.ppm'
8-ppm_url = ("https://wiki.linaro.org/TestDataLinkPage?action=AttachFile&"
9- "do=get&target=nightshot_iso_100.ppm")
10+ppm_url = ("http://testdata.validation.linaro.org/tjbench/"
11+ "nightshot_iso_100.ppm")
12 ppm_temp_path = os.path.join(config.tempdir_host, ppm_file_name)
13 ppm_android_path = os.path.join(config.tempdir_android, test_name,
14 ppm_file_name)
15@@ -81,30 +81,30 @@
16 match = measure_pat.search(line)
17 if match:
18 tmpdata = match.groupdict()
19- test_case_preffix = '%s_%s_%s' % (tmpdata['format'],
20+ test_case_prefix = '%s_%s_%s' % (tmpdata['format'],
21 tmpdata['subsamp'],
22 tmpdata['qual'])
23- if not prefix_hash.get(test_case_preffix):
24- prefix_hash[test_case_preffix] = True
25- test_case_preffix = '%s_%s' % (test_case_preffix,
26+ if not prefix_hash.get(test_case_prefix):
27+ prefix_hash[test_case_prefix] = True
28+ test_case_prefix = '%s_%s' % (test_case_prefix,
29 'scale_half')
30 common_data = {'log_filename': result_filename,
31 'log_lineno': lineno,
32 'result': 'pass'
33 }
34- comp_perf = {'test_case_id': '%s_%s' % (test_case_preffix,
35+ comp_perf = {'test_case_id': '%s_%s' % (test_case_prefix,
36 'comp_perf'),
37 'units': units,
38 'measurement': tmpdata['comp_perf']
39 }
40 comp_perf.update(common_data)
41- comp_ratio = {'test_case_id': '%s_%s' % (test_case_preffix,
42+ comp_ratio = {'test_case_id': '%s_%s' % (test_case_prefix,
43 'comp_ratio'),
44 'units': '%',
45 'measurement': tmpdata['comp_ratio']
46 }
47 comp_ratio.update(common_data)
48- dcomp_perf = {'test_case_id': '%s_%s' % (test_case_preffix,
49+ dcomp_perf = {'test_case_id': '%s_%s' % (test_case_prefix,
50 'dcomp_perf'),
51 'units': units,
52 'measurement': tmpdata['dcomp_perf']

Subscribers

People subscribed via source and target branches