LAVA Android Test

Merge lp:~liuyq0307/lava-android-test/fix-1012573 into lp:lava-android-test

  1. fix-1012573
  2. Merge into trunk
Proposed by Yongqin Liu
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 165
Merged at revision: 165
Proposed branch: lp:~liuyq0307/lava-android-test/fix-1012573
Merge into: lp:lava-android-test
Diff against target: 12 lines (+1/-1)
1 file modified
lava_android_test/swprofile.py (+1/-1)
To merge this branch: bzr merge lp:~liuyq0307/lava-android-test/fix-1012573
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle (community) Approve
Review via email: mp+110015@code.launchpad.net

Description of the change

return empty string when can not get the ro.build.display.id property

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

you can do this easier with just:

  return props.get('ro.build.display.id', '')

lp:~liuyq0307/lava-android-test/fix-1012573 updated
165. By Yongqin Liu

modify according to the review comment

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> you can do this easier with just:
>
> return props.get('ro.build.display.id', '')

Ah, yeah, thanks.
updated.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Looks sane to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_android_test/swprofile.py'
2--- lava_android_test/swprofile.py 2012-03-08 11:29:09 +0000
3+++ lava_android_test/swprofile.py 2012-06-14 01:50:21 +0000
4@@ -43,7 +43,7 @@
5
6 def get_image_name_from_properties(adb=ADB()):
7 props = get_properties(adb)
8- return props.get('ro.build.display.id')
9+ return props.get('ro.build.display.id', '')
10
11
12 def get_source_info(adb=ADB()):

Subscribers

People subscribed via source and target branches