Merge lp:~liuyq0307/lava-android-test/cts-not-failed into lp:lava-android-test

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 137
Proposed branch: lp:~liuyq0307/lava-android-test/cts-not-failed
Merge into: lp:lava-android-test
Diff against target: 15 lines (+5/-2)
1 file modified
lava_android_test/test_definitions/cts/cts_wrapper.sh (+5/-2)
To merge this branch: bzr merge lp:~liuyq0307/lava-android-test/cts-not-failed
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Yongqin Liu self review Approve
Review via email: mp+92548@code.launchpad.net

Description of the change

make the cts command always return 0 so that we can also get some test results from cts execution

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

approved by myself

review: Approve (self review)
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

In general I don't think we should ever care about the exit code. I don't know the architecture for android parts so I cannot comment further. Please seek another review if needed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_android_test/test_definitions/cts/cts_wrapper.sh'
2--- lava_android_test/test_definitions/cts/cts_wrapper.sh 2012-01-18 14:00:53 +0000
3+++ lava_android_test/test_definitions/cts/cts_wrapper.sh 2012-02-10 18:23:28 +0000
4@@ -74,5 +74,8 @@
5 rm -f tee cts_output.log
6 if [ ${RET_CODE} -ne 0 ]; then
7 echo "Faild to run cts for test (${test_str})"
8- exit 1
9-fi
10\ No newline at end of file
11+### comment it so that we can get the test result that has been executed
12+### otherwise we won't get any test result about cts
13+# exit 1
14+fi
15+exit 0

Subscribers

People subscribed via source and target branches