Merge ~liushuyu-011/ubuntu/+source/scrollz:ubuntu/devel into ubuntu/+source/scrollz:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merged at revision: fa0acfc01192c0be16d9147f41f24b8edbdebb9e
Proposed branch: ~liushuyu-011/ubuntu/+source/scrollz:ubuntu/devel
Merge into: ubuntu/+source/scrollz:ubuntu/devel
Diff against target: 161 lines (+139/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/gcc13.patch (+131/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Steve Langasek (community) Approve
Review via email: mp+464236@code.launchpad.net

Description of the change

This MP fixes an FTBFS on armhf after the time_t transition that made compiler stricter.

To post a comment you must log in.
Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f50b698..b3c103c 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+scrollz (2.2.3-2ubuntu1) noble; urgency=medium
7+
8+ * debian/patches/gcc13.patch: Fix build with GCC 13 and add missing
9+ includes. Closes LP: #2061184.
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Fri, 12 Apr 2024 16:18:51 -0600
12+
13 scrollz (2.2.3-2build2) noble; urgency=medium
14
15 * No-change rebuild for CVE-2024-3094
16diff --git a/debian/patches/gcc13.patch b/debian/patches/gcc13.patch
17new file mode 100644
18index 0000000..81cc772
19--- /dev/null
20+++ b/debian/patches/gcc13.patch
21@@ -0,0 +1,131 @@
22+Description: Fix build with GCC 13 and add missing includes
23+ Also included missing function prototypes
24+Author: Zixing Liu <zixing.liu@canonical.com>
25+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066483
26+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/scrollz/+bug/2061184
27+Forwarded: no
28+Last-Update: 2024-04-12
29+---
30+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
31+Index: scrollz/configure
32+===================================================================
33+--- scrollz.orig/configure
34++++ scrollz/configure
35+@@ -2317,6 +2317,7 @@ else
36+ /* System header to define __stub macros and hopefully few prototypes,
37+ which can conflict with char snprintf(); below. */
38+ #include <assert.h>
39++#include <stdio.h>
40+ /* Override any gcc2 internal prototype to avoid an error. */
41+ /* We use char because int might match the return type of a gcc2
42+ builtin and then its argument prototype would still apply. */
43+@@ -2368,6 +2369,7 @@ else
44+ /* System header to define __stub macros and hopefully few prototypes,
45+ which can conflict with char vsnprintf(); below. */
46+ #include <assert.h>
47++#include <stdio.h>
48+ /* Override any gcc2 internal prototype to avoid an error. */
49+ /* We use char because int might match the return type of a gcc2
50+ builtin and then its argument prototype would still apply. */
51+@@ -2536,6 +2538,7 @@ else
52+ #line 2537 "configure"
53+ #include "confdefs.h"
54+ #include <ctype.h>
55++#include <stdlib.h>
56+ #define ISLOWER(c) ('a' <= (c) && (c) <= 'z')
57+ #define TOUPPER(c) (ISLOWER(c) ? 'A' + ((c) - 'a') : (c))
58+ #define XOR(e, f) (((e) && !(f)) || (!(e) && (f)))
59+@@ -5472,6 +5475,7 @@ else
60+ #include <string.h>
61+ #include <sys/socket.h>
62+ #include <netinet/in.h>
63++#include <stdlib.h>
64+
65+ main()
66+ {
67+Index: scrollz/include/edit.h
68+===================================================================
69+--- scrollz.orig/include/edit.h
70++++ scrollz/include/edit.h
71+@@ -72,7 +72,7 @@ extern u_char *recv_nick;
72+ void command_completion _((u_int, char *));
73+ void e_quit _((char *, char *, char *));
74+ int check_wait_command _((char *));
75+-
76++ int GrabURL _((char *, char *, char *, char *));
77+ #define AWAY_ONE 0
78+ #define AWAY_ALL 1
79+
80+Index: scrollz/include/trace.h
81+===================================================================
82+--- scrollz.orig/include/trace.h
83++++ scrollz/include/trace.h
84+@@ -29,4 +29,6 @@ void TraceChannelInfo _((int indent, Cha
85+ void TraceNickListInfo _((int indent, NickList *nicks));
86+ void TraceWindowInfo _((int indent, Window *window));
87+
88++void Trace(long area, char *format, ...);
89++
90+ #endif
91+Index: scrollz/source/edit.c
92+===================================================================
93+--- scrollz.orig/source/edit.c
94++++ scrollz/source/edit.c
95+@@ -101,6 +101,7 @@ static void send_action _((char *, char
96+
97+ TimerList *PendingTimers = (TimerList *) 0;
98+
99++extern void PopLine(void);
100+ /* used with input_move_cursor */
101+ #define RIGHT 1
102+ #define LEFT 0
103+Index: scrollz/source/edit2.c
104+===================================================================
105+--- scrollz.orig/source/edit2.c
106++++ scrollz/source/edit2.c
107+@@ -195,6 +195,8 @@ static char *celeawaystr=(char *) 0;
108+ static time_t CeleAwayTime=0;
109+ #endif
110+ extern char *CelerityNtfy;
111++extern int DecryptMessage _((char *, char *));
112++extern int EncryptMessage _((char *, char *));
113+
114+ /* Kicks all unopped people from current channel */
115+ void LameKick(command,args,subargs)
116+Index: scrollz/source/edit3.c
117+===================================================================
118+--- scrollz.orig/source/edit3.c
119++++ scrollz/source/edit3.c
120+@@ -96,6 +96,7 @@ extern NickList * find_in_hash _((Channe
121+
122+ extern void dcc_chat _((char *));
123+ extern void dcc_close _((char *));
124++extern int DecryptString _((char *, char *, char *, int, int));
125+
126+ extern char *ScrollZver1;
127+ extern char *CelerityNtfy;
128+Index: scrollz/source/numbers.c
129+===================================================================
130+--- scrollz.orig/source/numbers.c
131++++ scrollz/source/numbers.c
132+@@ -104,6 +104,8 @@ extern void HandleStatsD _((char *, char
133+ #ifdef CELE
134+ extern void HandleTrace _((int, char *, char *, char *, char *, char *, char *));
135+ #endif
136++extern int DecryptMessage _((char *, char *));
137++extern int EncryptMessage _((char *, char *));
138+
139+ extern void userhost _((char *, char *, char *));
140+ /* ***************** */
141+Index: scrollz/source/trace.c
142+===================================================================
143+--- scrollz.orig/source/trace.c
144++++ scrollz/source/trace.c
145+@@ -9,6 +9,7 @@
146+ #include "ircaux.h"
147+ #include "server.h"
148+ #include "trace.h"
149++#include "output.h"
150+
151+ #ifdef SZTRACE
152+ extern char *OpenCreateFile(char *, int);
153diff --git a/debian/patches/series b/debian/patches/series
154index bd78f80..55fde19 100644
155--- a/debian/patches/series
156+++ b/debian/patches/series
157@@ -6,3 +6,4 @@ rijndael-prototypes.patch
158 sys-stat-h.patch
159 CVE-2021-29376.patch
160 CVE-2021-29376-update.patch
161+gcc13.patch

Subscribers

People subscribed via source and target branches

to all changes: